Changeset 47405 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Aug 17, 2009, 6:05:37 PM (16 years ago)

Author:

[email protected]

Message:

Fix 300,000+ leaks seen during the regression tests.

Reviewed by Darin Adler.

EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.

• bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

• runtime/Executable.h:

(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):

File:

• trunk/JavaScriptCore/runtime/Executable.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/Executable.h

@@ -57 +57 @@
     };
 
-    class EvalExecutable : public TemplateExecutable<EvalNode, EvalCodeBlock>, public RefCounted<EvalExecutable> {
+    class EvalExecutable : public TemplateExecutable<EvalNode, EvalCodeBlock> {
     public:
         EvalExecutable(const SourceCode& source)
@@ -65 +65 @@
 
         JSObject* parse(ExecState* exec, bool allowDebug = true);
+    };
+
+    class CacheableEvalExecutable : public EvalExecutable, public RefCounted<CacheableEvalExecutable> {
+    public:
+        static PassRefPtr<CacheableEvalExecutable> create(const SourceCode& source) { return adoptRef(new CacheableEvalExecutable(source)); }
+
+    private:
+        CacheableEvalExecutable(const SourceCode& source)
+            : EvalExecutable(source)
+        {
+        }
     };