Changeset 47622 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Timestamp:

Aug 20, 2009, 10:41:54 PM (16 years ago)

Author:

[email protected]

Message:

Added a number => string cache.

Patch by Geoffrey Garen <​[email protected]> on 2009-08-20
Reviewed by Maciej Stachowiak.

1.07x faster on v8 (1.7x faster on v8-splay).
1.004x faster on SunSpider.

• runtime/JSCell.h: Moved JSValue::toString to JSString.h.
• runtime/JSGlobalData.h: Holds the cache.
• runtime/JSNumberCell.cpp:

(JSC::JSNumberCell::toString):
(JSC::JSNumberCell::toThisString): Removed -0 special case.
UString handles this now, since too many clients were
special-casing it.

• runtime/JSString.h:

(JSC::JSValue::toString): Use the cache when converting
an int or double to string.

• runtime/Operations.h:

(JSC::concatenateStrings): Call toString to take advantage
of the cache.

• runtime/SmallStrings.h:

(JSC::NumericStrings::add):
(JSC::NumericStrings::lookup): The cache.

• runtime/UString.cpp:

(JSC::UString::from): Added -0 special case mentioned above.
Removed appendNumeric because it's mutually exclusive with the
cache.

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (4 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -68 +68 @@
                 1429DAE00ED2645B00B89619 /* WRECGenerator.h in Headers */ = {isa = PBXBuildFile; fileRef = 1429DADE0ED2645B00B89619 /* WRECGenerator.h */; };
                 1429DAE10ED2645B00B89619 /* WRECGenerator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1429DADF0ED2645B00B89619 /* WRECGenerator.cpp */; };
+                142D3939103E4560007DCB52 /* NumericStrings.h in Headers */ = {isa = PBXBuildFile; fileRef = 142D3938103E4560007DCB52 /* NumericStrings.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 143A97E60A4A06E200456B66 /* CoreFoundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 6560A4CF04B3B3E7008AE952 /* CoreFoundation.framework */; };
                 1440057F0A5335640005F061 /* JSNode.c in Sources */ = {isa = PBXBuildFile; fileRef = 1440F6420A4F8B6A0005F061 /* JSNode.c */; };
@@ -505 +506 @@
                 1429DADE0ED2645B00B89619 /* WRECGenerator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WRECGenerator.h; sourceTree = "<group>"; };
                 1429DADF0ED2645B00B89619 /* WRECGenerator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WRECGenerator.cpp; sourceTree = "<group>"; };
+                142D3938103E4560007DCB52 /* NumericStrings.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NumericStrings.h; sourceTree = "<group>"; };
                 1440051F0A531D3B0005F061 /* Node.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Node.h; path = tests/Node.h; sourceTree = "<group>"; };
                 144005200A531D3B0005F061 /* Node.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = Node.c; path = tests/Node.c; sourceTree = "<group>"; };
@@ -1456 +1458 @@
                                 BC2680C40E16D4E900A06E92 /* NumberPrototype.cpp */,
                                 BC2680C50E16D4E900A06E92 /* NumberPrototype.h */,
+                                142D3938103E4560007DCB52 /* NumericStrings.h */,
                                 BC2680C60E16D4E900A06E92 /* ObjectConstructor.cpp */,
                                 BC2680C70E16D4E900A06E92 /* ObjectConstructor.h */,
@@ -1912 +1915 @@
                                 A7D649AA1015224E009B2E1B /* PossiblyNull.h in Headers */,
                                 86CAFEE31035DDE60028A609 /* Executable.h in Headers */,
+                                142D3939103E4560007DCB52 /* NumericStrings.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;