Changeset 48336 in webkit for trunk/JavaScriptCore/debugger

Timestamp:

Sep 12, 2009, 7:44:32 PM (16 years ago)

Author:

[email protected]

Message:

[ES5] Implement Object.keys
​https://bugs.webkit.org/show_bug.cgi?id=29170

Reviewed by Maciej Stachowiak.

This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot. In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.

Location:

trunk/JavaScriptCore/debugger

Files:

• DebuggerActivation.cpp (modified) (1 diff)
• DebuggerActivation.h (modified) (1 diff)

trunk/JavaScriptCore/debugger/DebuggerActivation.cpp

@@ -72 +72 @@
 }
 
-void DebuggerActivation::getPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
+void DebuggerActivation::getOwnPropertyNames(ExecState* exec, PropertyNameArray& propertyNames)
 {
     m_activation->getPropertyNames(exec, propertyNames);

trunk/JavaScriptCore/debugger/DebuggerActivation.h

@@ -43 +43 @@
         virtual void putWithAttributes(ExecState*, const Identifier& propertyName, JSValue, unsigned attributes);
         virtual bool deleteProperty(ExecState*, const Identifier& propertyName);
-        virtual void getPropertyNames(ExecState*, PropertyNameArray&);
+        virtual void getOwnPropertyNames(ExecState*, PropertyNameArray&);
         virtual bool getPropertyAttributes(ExecState*, const Identifier& propertyName, unsigned& attributes) const;
         virtual void defineGetter(ExecState*, const Identifier& propertyName, JSObject* getterFunction);