Changeset 48623 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 22, 2009, 3:30:55 AM (16 years ago)

Author:

Simon Hausmann

Message:

Fix major memory leak in JavaScriptCore RegisterFile on Windows CE

Patch by Joerg Bornemann <​[email protected]> on 2009-09-22
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=29367

On Widows CE we must decommit all committed pages before we release
them. See VirtualFree documentation.
Desktop Windows behaves much smoother in this situation.

• interpreter/RegisterFile.cpp:

(JSC::RegisterFile::~RegisterFile):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/RegisterFile.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-09-22  Joerg Bornemann  <[email protected]>
+
+        Reviewed by Simon Hausmann.
+
+        Fix major memory leak in JavaScriptCore RegisterFile on Windows CE
+
+        https://bugs.webkit.org/show_bug.cgi?id=29367
+
+        On Widows CE we must decommit all committed pages before we release
+        them. See VirtualFree documentation.
+        Desktop Windows behaves much smoother in this situation.
+
+        * interpreter/RegisterFile.cpp:
+        (JSC::RegisterFile::~RegisterFile):
+
 2009-09-21  Greg Bolsinga  <[email protected]>
 

trunk/JavaScriptCore/interpreter/RegisterFile.cpp

@@ -37 +37 @@
     munmap(m_buffer, ((m_max - m_start) + m_maxGlobals) * sizeof(Register));
 #elif HAVE(VIRTUALALLOC)
+#if PLATFORM(WINCE)
+    VirtualFree(m_buffer, DWORD(m_commitEnd) - DWORD(m_buffer), MEM_DECOMMIT);
+#endif
     VirtualFree(m_buffer, 0, MEM_RELEASE);
 #else