Changeset 48732 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 24, 2009, 2:18:26 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore: Renamed clear to removeAll, as suggested by Darin Adler.

Patch by Geoffrey Garen <​[email protected]> on 2009-09-24
Reviewed by Sam Weinig.

• wtf/HashCountedSet.h:

(WTF::::removeAll):

WebCore: Added back enable/disableSuddenTermination() functionality I accidentally
removed in my last patch.

Patch by Geoffrey Garen <​[email protected]> on 2009-09-24
Reviewed by Sam Weinig.

• page/DOMWindow.cpp:

(WebCore::addUnloadEventListener):
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::addBeforeUnloadEventListener):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/HashCountedSet.h (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-09-24  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Sam Weinig.
+
+        Renamed clear to removeAll, as suggested by Darin Adler.
+
+        * wtf/HashCountedSet.h:
+        (WTF::::removeAll):
+
 2009-09-24  Mark Rowe  <[email protected]>
 

trunk/JavaScriptCore/wtf/HashCountedSet.h

@@ -66 +66 @@
  
         // removes the value, regardless of its count
-        void clear(iterator);
-        void clear(const ValueType&);
+        void removeAll(iterator);
+        void removeAll(const ValueType&);
 
         // clears the whole set
@@ -172 +172 @@
     
     template<typename Value, typename HashFunctions, typename Traits>
-    inline void HashCountedSet<Value, HashFunctions, Traits>::clear(const ValueType& value)
-    {
-        clear(find(value));
-    }
-    
-    template<typename Value, typename HashFunctions, typename Traits>
-    inline void HashCountedSet<Value, HashFunctions, Traits>::clear(iterator it)
+    inline void HashCountedSet<Value, HashFunctions, Traits>::removeAll(const ValueType& value)
+    {
+        removeAll(find(value));
+    }
+    
+    template<typename Value, typename HashFunctions, typename Traits>
+    inline void HashCountedSet<Value, HashFunctions, Traits>::removeAll(iterator it)
     {
         if (it == end())