Changeset 50173 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 27, 2009, 2:51:23 PM (16 years ago)

Author:

[email protected]

Message:

2009-10-27 James Robinson <​[email protected]>

Reviewed by Darin Fisher.

Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.

Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See ​http://code.google.com/p/chromium/issues/detail?id=25892 for an example.

​https://bugs.webkit.org/show_bug.cgi?id=30833

• JavaScriptCore.gyp/JavaScriptCore.gyp:
• wtf/CurrentTime.cpp:

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• JavaScriptCore.gyp/JavaScriptCore.gyp (modified) (1 diff)
• wtf/CurrentTime.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-10-27  James Robinson  <[email protected]>
+
+        Reviewed by Darin Fisher.
+
+        Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.
+
+        Chromium uses a different method to calculate the current time than is used in
+        JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
+        function are mixed.  In particular, timers can get scheduled in the past which leads to 100% CPU use.
+        See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30833
+
+        * JavaScriptCore.gyp/JavaScriptCore.gyp:
+        * wtf/CurrentTime.cpp:
+
 2009-10-27  Peter Varga  <[email protected]>
 

trunk/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp

@@ -122 +122 @@
         ['exclude', '/(GOwnPtr|glib/.*)\\.(cpp|h)$'],
         ['exclude', '(Default|Gtk|Mac|None|Qt|Win|Wx)\\.(cpp|mm)$'],
+        ['exclude', 'wtf/CurrentTime\\.cpp$'],
       ],
       'direct_dependent_settings': {

trunk/JavaScriptCore/wtf/CurrentTime.cpp

@@ -64 +64 @@
 #endif
 
+#if PLATFORM(CHROMIUM)
+#error Chromium uses a different timer implementation
+#endif
+
 namespace WTF {