Changeset 50174 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Timestamp:

Oct 27, 2009, 3:01:41 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=30800
Cache recently computed date data.

Patch by Geoffrey Garen <​[email protected]> on 2009-10-27
Reviewed by Darin Adler and Oliver Hunt.

SunSpider reports a ~0.5% speedup, mostly from date-format-tofte.js.

• GNUmakefile.am:
• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj: Added new file.

• runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):
(JSC::DateInstance::getGregorianDateTime): Use the shared cache.

• runtime/DateInstance.h: Renamed m_cache to m_data, to avoid the confusion

of a "cache cache".

• runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Pass an ExecState to these functions, so they
can access the DateInstanceCache.

• runtime/JSGlobalData.h: Keep a DateInstanceCache.

JavaScriptGlue: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <​[email protected]> on 2009-10-27
Reviewed by Oliver Hunt.

• ForwardingHeaders/wtf/DateMath.h: Added.

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (9 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -158 +158 @@
                 148F21BC107EC54D0042EC2C /* Parser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93F0B3A909BB4DC00068FCE3 /* Parser.cpp */; };
                 149559EE0DDCDDF700648087 /* DebuggerCallFrame.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 149559ED0DDCDDF700648087 /* DebuggerCallFrame.cpp */; };
+                14A1563210966365006FA260 /* DateInstanceCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 14A1563010966365006FA260 /* DateInstanceCache.h */; };
                 14A23D750F4E1ABB0023CDAD /* JITStubs.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14A23D6C0F4E19CE0023CDAD /* JITStubs.cpp */; };
                 14A42E3F0F4F60EE00599099 /* TimeoutChecker.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14A42E3D0F4F60EE00599099 /* TimeoutChecker.cpp */; };
@@ -616 +617 @@
                 149559ED0DDCDDF700648087 /* DebuggerCallFrame.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DebuggerCallFrame.cpp; sourceTree = "<group>"; };
                 149B24FF0D8AF6D1009CB8C7 /* Register.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Register.h; sourceTree = "<group>"; };
+                14A1563010966365006FA260 /* DateInstanceCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DateInstanceCache.h; sourceTree = "<group>"; };
                 14A23D6C0F4E19CE0023CDAD /* JITStubs.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JITStubs.cpp; sourceTree = "<group>"; };
                 14A396A60CD2933100B5B4FF /* SymbolTable.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SymbolTable.h; sourceTree = "<group>"; };
@@ -1417 +1419 @@
                         isa = PBXGroup;
                         children = (
-                                A7FB604B103F5EAB0017A286 /* PropertyDescriptor.h */,
                                 BCF605110E203EF800B9A64D /* ArgList.cpp */,
                                 BCF605120E203EF800B9A64D /* ArgList.h */,
@@ -1451 +1452 @@
                                 BC1166000E1997B1008066DD /* DateInstance.cpp */,
                                 BC1166010E1997B1008066DD /* DateInstance.h */,
+                                14A1563010966365006FA260 /* DateInstanceCache.h */,
                                 BCD203470E17135E002C7E82 /* DatePrototype.cpp */,
                                 BCD203480E17135E002C7E82 /* DatePrototype.h */,
@@ -1514 +1516 @@
                                 F692A8620255597D01FF60F7 /* JSString.h */,
                                 14ABB454099C2A0F00E2A24F /* JSType.h */,
+                                6507D2970E871E4A00D7D896 /* JSTypeInfo.h */,
                                 F692A8870255597D01FF60F7 /* JSValue.cpp */,
                                 14ABB36E099C076400E2A24F /* JSValue.h */,
@@ -1524 +1527 @@
                                 F692A8680255597D01FF60F7 /* Lookup.cpp */,
                                 F692A8690255597D01FF60F7 /* Lookup.h */,
+                                A74B3498102A5F8E0032AB98 /* MarkStack.cpp */,
+                                A779558F101A74D500114E55 /* MarkStack.h */,
+                                A7C530E3102A3813005BC741 /* MarkStackPosix.cpp */,
                                 F692A86A0255597D01FF60F7 /* MathObject.cpp */,
                                 F692A86B0255597D01FF60F7 /* MathObject.h */,
@@ -1544 +1550 @@
                                 F692A8770255597D01FF60F7 /* Operations.cpp */,
                                 F692A8780255597D01FF60F7 /* Operations.h */,
+                                A7FB60A3103F7DC20017A286 /* PropertyDescriptor.cpp */,
+                                A7FB604B103F5EAB0017A286 /* PropertyDescriptor.h */,
                                 BC95437C0EBA70FD0072B6D3 /* PropertyMapHashTable.h */,
                                 65400C0F0A69BAF200509887 /* PropertyNameArray.cpp */,
@@ -1584 +1592 @@
                                 5D53726D0E1C546B0021E549 /* Tracing.d */,
                                 5D53726E0E1C54880021E549 /* Tracing.h */,
-                                6507D2970E871E4A00D7D896 /* JSTypeInfo.h */,
                                 F692A8850255597D01FF60F7 /* UString.cpp */,
                                 F692A8860255597D01FF60F7 /* UString.h */,
-                                A779558F101A74D500114E55 /* MarkStack.h */,
-                                A7C530E3102A3813005BC741 /* MarkStackPosix.cpp */,
-                                A74B3498102A5F8E0032AB98 /* MarkStack.cpp */,
-                                A7FB60A3103F7DC20017A286 /* PropertyDescriptor.cpp */,
                         );
                         path = runtime;
@@ -1999 +2002 @@
                                 BC87CDB910712AD4000614CF /* JSONObject.lut.h in Headers */,
                                 148CD1D8108CF902008163C6 /* JSContextRefPrivate.h in Headers */,
+                                14A1563210966365006FA260 /* DateInstanceCache.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;