Changeset 50183 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Oct 27, 2009, 4:29:40 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore: A little bit of refactoring in the date code.

Patch by Geoffrey Garen <​[email protected]> on 2009-10-27
Reviewed by Sam Weinig.

• JavaScriptCore.exp: Don't export this unused symbol.

• runtime/DateConstructor.cpp:

(JSC::constructDate):

• runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

• runtime/DateInstance.h: Removed some unused functions. Changed the default

constructor to ensure that a DateInstance is always initialized.

• runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
since it now requires one.

• wtf/DateMath.cpp:

(WTF::msToGregorianDateTime): Only compute our offset from UTC if our
output will require it. Otherwise, our offset is 0.

WebKit/mac: Updated for refactoring in the date code.

Patch by Geoffrey Garen <​[email protected]> on 2009-10-27
Reviewed by Sam Weinig.

• WebView/WebView.mm:

(aeDescFromJSValue): Since we just want a number of milliseconds, do that
instead of something more complicated.

Location:

trunk/JavaScriptCore/runtime

Files:

• DateConstructor.cpp (modified) (1 diff)
• DateInstance.cpp (modified) (2 diffs)
• DateInstance.h (modified) (1 diff)
• DatePrototype.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/DateConstructor.cpp

@@ -113 +113 @@
     }
 
-    DateInstance* result = new (exec) DateInstance(exec->lexicalGlobalObject()->dateStructure());
-    result->setInternalValue(jsNumber(exec, timeClip(value)));
-    return result;
+    return new (exec) DateInstance(exec, value);
 }
     

trunk/JavaScriptCore/runtime/DateInstance.cpp

@@ -35 +35 @@
 const ClassInfo DateInstance::info = {"Date", 0, 0, 0};
 
-DateInstance::DateInstance(NonNullPassRefPtr<Structure> structure)
+DateInstance::DateInstance(ExecState* exec, NonNullPassRefPtr<Structure> structure)
     : JSWrapperObject(structure)
 {
+    setInternalValue(jsNaN(exec));
 }
 
@@ -72 +73 @@
 }
 
-bool DateInstance::getTime(GregorianDateTime& t, int& offset) const
-{
-    double milli = internalNumber();
-    if (isnan(milli))
-        return false;
-    
-    msToGregorianDateTime(milli, false, t);
-    offset = gmtoffset(t);
-    return true;
-}
-
-bool DateInstance::getUTCTime(GregorianDateTime& t) const
-{
-    double milli = internalNumber();
-    if (isnan(milli))
-        return false;
-    
-    msToGregorianDateTime(milli, true, t);
-    return true;
-}
-
-bool DateInstance::getTime(double& milli, int& offset) const
-{
-    milli = internalNumber();
-    if (isnan(milli))
-        return false;
-    
-    GregorianDateTime t;
-    msToGregorianDateTime(milli, false, t);
-    offset = gmtoffset(t);
-    return true;
-}
-
-bool DateInstance::getUTCTime(double& milli) const
-{
-    milli = internalNumber();
-    if (isnan(milli))
-        return false;
-    
-    return true;
-}
-
 } // namespace JSC

trunk/JavaScriptCore/runtime/DateInstance.h

@@ -33 +33 @@
     public:
         DateInstance(ExecState*, double);
-        explicit DateInstance(NonNullPassRefPtr<Structure>);
+        explicit DateInstance(ExecState*, NonNullPassRefPtr<Structure>);
 
         double internalNumber() const { return internalValue().uncheckedGetNumber(); }
-
-        bool getTime(WTF::GregorianDateTime&, int& offset) const;
-        bool getUTCTime(WTF::GregorianDateTime&) const;
-        bool getTime(double& milliseconds, int& offset) const;
-        bool getUTCTime(double& milliseconds) const;
 
         static JS_EXPORTDATA const ClassInfo info;

trunk/JavaScriptCore/runtime/DatePrototype.cpp

@@ -398 +398 @@
 
 DatePrototype::DatePrototype(ExecState* exec, NonNullPassRefPtr<Structure> structure)
-    : DateInstance(structure)
-{
-    setInternalValue(jsNaN(exec));
+    : DateInstance(exec, structure)
+{
     // The constructor will be added later, after DateConstructor has been built.
 }