Changeset 50183 in webkit for trunk/JavaScriptCore/wtf

Timestamp:

Oct 27, 2009, 4:29:40 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore: A little bit of refactoring in the date code.

Patch by Geoffrey Garen <​[email protected]> on 2009-10-27
Reviewed by Sam Weinig.

• JavaScriptCore.exp: Don't export this unused symbol.

• runtime/DateConstructor.cpp:

(JSC::constructDate):

• runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

• runtime/DateInstance.h: Removed some unused functions. Changed the default

constructor to ensure that a DateInstance is always initialized.

• runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
since it now requires one.

• wtf/DateMath.cpp:

(WTF::msToGregorianDateTime): Only compute our offset from UTC if our
output will require it. Otherwise, our offset is 0.

WebKit/mac: Updated for refactoring in the date code.

Patch by Geoffrey Garen <​[email protected]> on 2009-10-27
Reviewed by Sam Weinig.

• WebView/WebView.mm:

(aeDescFromJSValue): Since we just want a number of milliseconds, do that
instead of something more complicated.

File:

• trunk/JavaScriptCore/wtf/DateMath.cpp (modified) (2 diffs)

trunk/JavaScriptCore/wtf/DateMath.cpp

@@ -502 +502 @@
 }
 
+// input is UTC
 void msToGregorianDateTime(double ms, bool outputIsUTC, GregorianDateTime& tm)
 {
-    // input is UTC
     double dstOff = 0.0;
-    const double utcOff = getUTCOffset();
-
-    if (!outputIsUTC) {  // convert to local time
+    double utcOff = 0.0;
+    if (!outputIsUTC) {
+        utcOff = getUTCOffset();
         dstOff = getDSTOffset(ms, utcOff);
         ms += dstOff + utcOff;
@@ -523 +523 @@
     tm.year     =  year - 1900;
     tm.isDST    =  dstOff != 0.0;
-
-    tm.utcOffset = outputIsUTC ? 0 : static_cast<long>((dstOff + utcOff) / msPerSecond);
+    tm.utcOffset = static_cast<long>((dstOff + utcOff) / msPerSecond);
     tm.timeZone = NULL;
 }