Changeset 50789 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Nov 10, 2009, 11:22:30 PM (16 years ago)

Author:

[email protected]

Message:

Faster Math.random, based on GameRand.

Reviewed by Gavin "avGni arBalroguch" Barraclough.

SunSpider says 1.4% faster.

• GNUmakefile.am:
• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj: Added the header to the project.

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

• runtime/JSGlobalData.h: Use an object to track random number generation

state, initialized to the current time.

• runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::mathProtoFuncRandom): Use the new hotness.

• runtime/WeakRandom.h: Added.

(JSC::WeakRandom::WeakRandom):
(JSC::WeakRandom::get):
(JSC::WeakRandom::advance): The new hotness.

Location:

trunk/JavaScriptCore/runtime

Files:

• JSGlobalData.cpp (modified) (1 diff)
• JSGlobalData.h (modified) (2 diffs)
• MathObject.cpp (modified) (2 diffs)
• WeakRandom.h (added)

trunk/JavaScriptCore/runtime/JSGlobalData.cpp

@@ -149 +149 @@
     , markStack(vptrSet.jsArrayVPtr)
     , cachedUTCOffset(NaN)
+    , weakRandom(static_cast<int>(currentTime()))
 #ifndef NDEBUG
     , mainThreadOnly(false)

trunk/JavaScriptCore/runtime/JSGlobalData.h

@@ -39 +39 @@
 #include "SmallStrings.h"
 #include "TimeoutChecker.h"
+#include "WeakRandom.h"
 #include <wtf/Forward.h>
 #include <wtf/HashMap.h>
@@ -179 +180 @@
         UString cachedDateString;
         double cachedDateStringValue;
+        
+        WeakRandom weakRandom;
 
 #ifndef NDEBUG

trunk/JavaScriptCore/runtime/MathObject.cpp

@@ -97 +97 @@
     putDirectWithoutTransition(Identifier(exec, "SQRT1_2"), jsNumber(exec, sqrt(0.5)), DontDelete | DontEnum | ReadOnly);
     putDirectWithoutTransition(Identifier(exec, "SQRT2"), jsNumber(exec, sqrt(2.0)), DontDelete | DontEnum | ReadOnly);
-    WTF::initializeWeakRandomNumberGenerator();
 }
 
@@ -212 +211 @@
 JSValue JSC_HOST_CALL mathProtoFuncRandom(ExecState* exec, JSObject*, JSValue, const ArgList&)
 {
-    return jsNumber(exec, WTF::weakRandomNumber());
+    return jsNumber(exec, exec->globalData().weakRandom.get());
 }