Changeset 51457 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Nov 28, 2009, 2:31:18 AM (15 years ago)

Author:

[email protected]

Message:

2009-11-28 Zoltan Herczeg <​[email protected]>

Reviewed by Gavin Barraclough.

​https://bugs.webkit.org/show_bug.cgi?id=31930

Seems a typo. We don't need ~270k memory to determine the vptrs.

• runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):

File:

• trunk/JavaScriptCore/runtime/JSGlobalData.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSGlobalData.cpp

@@ -91 +91 @@
 VPtrSet::VPtrSet()
 {
-    // Bizarrely, calling fastMalloc here is faster than allocating space on the stack.
-    void* storage = fastMalloc(sizeof(CollectorBlock));
-
+    CollectorCell cell;
+    void* storage = &cell;
+
+    ASSERT(sizeof(JSArray) <= sizeof(CollectorCell));
     JSCell* jsArray = new (storage) JSArray(JSArray::createStructure(jsNull()));
     jsArrayVPtr = jsArray->vptr();
     jsArray->~JSCell();
 
+    ASSERT(sizeof(JSByteArray) <= sizeof(CollectorCell));
     JSCell* jsByteArray = new (storage) JSByteArray(JSByteArray::VPtrStealingHack);
     jsByteArrayVPtr = jsByteArray->vptr();
     jsByteArray->~JSCell();
 
+    ASSERT(sizeof(JSString) <= sizeof(CollectorCell));
     JSCell* jsString = new (storage) JSString(JSString::VPtrStealingHack);
     jsStringVPtr = jsString->vptr();
     jsString->~JSCell();
 
+    ASSERT(sizeof(JSFunction) <= sizeof(CollectorCell));
     JSCell* jsFunction = new (storage) JSFunction(JSFunction::createStructure(jsNull()));
     jsFunctionVPtr = jsFunction->vptr();
     jsFunction->~JSCell();
-
-    fastFree(storage);
 }