Changeset 51928 in webkit for trunk/JavaScriptCore

Timestamp:

Dec 9, 2009, 3:01:31 PM (15 years ago)

Author:

[email protected]

Message:

2009-12-09 Zoltan Herczeg <​[email protected]>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31930

Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
The speedup is 25%.

• runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSGlobalData.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-12-09  Zoltan Herczeg  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31930
+
+        Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
+        The speedup is 25%.
+
+        * runtime/JSGlobalData.cpp:
+        (JSC::VPtrSet::VPtrSet):
+
 2009-12-09  Steve Block  <[email protected]>
 

trunk/JavaScriptCore/runtime/JSGlobalData.cpp

@@ -86 +86 @@
     void* storage = &cell;
 
-    ASSERT(sizeof(JSArray) <= sizeof(CollectorCell));
+    COMPILE_ASSERT(sizeof(JSArray) <= sizeof(CollectorCell), sizeof_JSArray_must_be_less_than_CollectorCell);
     JSCell* jsArray = new (storage) JSArray(JSArray::createStructure(jsNull()));
     jsArrayVPtr = jsArray->vptr();
     jsArray->~JSCell();
 
-    ASSERT(sizeof(JSByteArray) <= sizeof(CollectorCell));
+    COMPILE_ASSERT(sizeof(JSByteArray) <= sizeof(CollectorCell), sizeof_JSByteArray_must_be_less_than_CollectorCell);
     JSCell* jsByteArray = new (storage) JSByteArray(JSByteArray::VPtrStealingHack);
     jsByteArrayVPtr = jsByteArray->vptr();
     jsByteArray->~JSCell();
 
-    ASSERT(sizeof(JSString) <= sizeof(CollectorCell));
+    COMPILE_ASSERT(sizeof(JSString) <= sizeof(CollectorCell), sizeof_JSString_must_be_less_than_CollectorCell);
     JSCell* jsString = new (storage) JSString(JSString::VPtrStealingHack);
     jsStringVPtr = jsString->vptr();
     jsString->~JSCell();
 
-    ASSERT(sizeof(JSFunction) <= sizeof(CollectorCell));
+    COMPILE_ASSERT(sizeof(JSFunction) <= sizeof(CollectorCell), sizeof_JSFunction_must_be_less_than_CollectorCell);
     JSCell* jsFunction = new (storage) JSFunction(JSFunction::createStructure(jsNull()));
     jsFunctionVPtr = jsFunction->vptr();