Changeset 51955 in webkit for trunk/JavaScriptCore

Timestamp:

Dec 10, 2009, 11:51:20 AM (15 years ago)

Author:

[email protected]

Message:

Fix three more things found by compiling with clang++.

Reviewed by Geoffrey Garen.

• runtime/Structure.h:

(JSC::StructureTransitionTable::reifySingleTransition):
Add the 'std' qualifier to the call to make_pair.

• wtf/DateMath.cpp:

(WTF::initializeDates):
Incrementing a bool is deprecated according to the C++ specification.

• wtf/PtrAndFlags.h:

(WTF::PtrAndFlags::PtrAndFlags):
Name lookup should not be done in dependent bases, so explicitly qualify the call to set.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Structure.h (modified) (1 diff)
• wtf/DateMath.cpp (modified) (1 diff)
• wtf/PtrAndFlags.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-12-09  Anders Carlsson  <[email protected]>
+
+        Reviewed by Geoffrey Garen.
+
+        Fix three more things found by compiling with clang++.
+        
+        * runtime/Structure.h:
+        (JSC::StructureTransitionTable::reifySingleTransition):
+        Add the 'std' qualifier to the call to make_pair.
+
+        * wtf/DateMath.cpp:
+        (WTF::initializeDates):
+        Incrementing a bool is deprecated according to the C++ specification.
+        
+        * wtf/PtrAndFlags.h:
+        (WTF::PtrAndFlags::PtrAndFlags):
+        Name lookup should not be done in dependent bases, so explicitly qualify the call to set.
+
 2009-12-09  Maciej Stachowiak  <[email protected]>
 

trunk/JavaScriptCore/runtime/Structure.h

@@ -308 +308 @@
         setTransitionTable(transitionTable);
         if (existingTransition)
-            add(make_pair(existingTransition->m_nameInPrevious.get(), existingTransition->m_attributesInPrevious), existingTransition, existingTransition->m_specificValueInPrevious);
+            add(std::make_pair(existingTransition->m_nameInPrevious.get(), existingTransition->m_attributesInPrevious), existingTransition, existingTransition->m_specificValueInPrevious);
     }
 } // namespace JSC

trunk/JavaScriptCore/wtf/DateMath.cpp

@@ -464 +464 @@
 #ifndef NDEBUG
     static bool alreadyInitialized;
-    ASSERT(!alreadyInitialized++);
+    ASSERT(!alreadyInitialized);
+    alreadyInitialized = true;
 #endif
 

trunk/JavaScriptCore/wtf/PtrAndFlags.h

@@ -69 +69 @@
         {
             PtrAndFlagsBase<T, FlagEnum>::m_ptrAndFlags = 0;
-            set(ptr);
+            PtrAndFlagsBase<T, FlagEnum>::set(ptr);
         }
     };