Ignore:
Timestamp:
Dec 13, 2009, 4:27:07 PM (16 years ago)
Author:
[email protected]
Message:

https://bugs.webkit.org/show_bug.cgi?id=32496
Switch remaining cases of string construction to use StringBuilder.
Builds strings using a vector rather than using string append / addition.

Reviewed by Sam Weinig.

(JSC::FunctionExecutable::paramString):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):
(JSC::Stringifier::indent):

  • runtime/JSString.h:
  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lexString):

  • runtime/NumberPrototype.cpp:

(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/Operations.h:

(JSC::jsString):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncConcat):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r52047 r52075  
    205205                869083150E6518D7000D36ED /* WREC.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 869083130E6518D7000D36ED /* WREC.cpp */; };
    206206                869083160E6518D7000D36ED /* WREC.h in Headers */ = {isa = PBXBuildFile; fileRef = 869083140E6518D7000D36ED /* WREC.h */; settings = {ATTRIBUTES = (Private, ); }; };
     207                8698B86910D44D9400D8D01B /* StringBuilder.h in Headers */ = {isa = PBXBuildFile; fileRef = 8698B86810D44D9400D8D01B /* StringBuilder.h */; };
    207208                869EBCB70E8C6D4A008722CC /* ResultType.h in Headers */ = {isa = PBXBuildFile; fileRef = 869EBCB60E8C6D4A008722CC /* ResultType.h */; settings = {ATTRIBUTES = (Private, ); }; };
    208209                86A90ED00EE7D51F00AB350D /* JITArithmetic.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 86A90ECF0EE7D51F00AB350D /* JITArithmetic.cpp */; };
     
    729730                869083130E6518D7000D36ED /* WREC.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WREC.cpp; sourceTree = "<group>"; };
    730731                869083140E6518D7000D36ED /* WREC.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WREC.h; sourceTree = "<group>"; };
     732                8698B86810D44D9400D8D01B /* StringBuilder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringBuilder.h; sourceTree = "<group>"; };
    731733                869EBCB60E8C6D4A008722CC /* ResultType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResultType.h; sourceTree = "<group>"; };
    732734                86A90ECF0EE7D51F00AB350D /* JITArithmetic.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JITArithmetic.cpp; sourceTree = "<group>"; };
     
    15311533                                65C7A1710A8EAACB00FA37EA /* JSWrapperObject.cpp */,
    15321534                                65C7A1720A8EAACB00FA37EA /* JSWrapperObject.h */,
     1535                                A7C2216810C745E000F97913 /* JSZombie.h */,
     1536                                A7C2216B10C7469C00F97913 /* JSZombie.cpp */,
    15331537                                A7E2EA6A0FB460CF00601F06 /* LiteralParser.cpp */,
    15341538                                A7E2EA690FB460CF00601F06 /* LiteralParser.h */,
     
    15831587                                93303FE80E6A72B500786E6A /* SmallStrings.cpp */,
    15841588                                93303FEA0E6A72C000786E6A /* SmallStrings.h */,
     1589                                8698B86810D44D9400D8D01B /* StringBuilder.h */,
    15851590                                BC18C3C00E16EE3300B34460 /* StringConstructor.cpp */,
    15861591                                BC18C3C10E16EE3300B34460 /* StringConstructor.h */,
     
    16031608                                F692A8860255597D01FF60F7 /* UString.h */,
    16041609                                1420BE7A10AA6DDB00F455D2 /* WeakRandom.h */,
    1605                                 A7C2216810C745E000F97913 /* JSZombie.h */,
    1606                                 A7C2216B10C7469C00F97913 /* JSZombie.cpp */,
    16071610                        );
    16081611                        path = runtime;
     
    20152018                                14A1563210966365006FA260 /* DateInstanceCache.h in Headers */,
    20162019                                1420BE7B10AA6DDB00F455D2 /* WeakRandom.h in Headers */,
     2020                                8698B86910D44D9400D8D01B /* StringBuilder.h in Headers */,
    20172021                        );
    20182022                        runOnlyForDeploymentPostprocessing = 0;
Note: See TracChangeset for help on using the changeset viewer.