Changeset 52981 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Jan 8, 2010, 3:17:27 AM (15 years ago)

Author:

[email protected]

Message:

2010-01-08 Kent Hansen <​[email protected]>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

• runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Kent Hansen <​[email protected]>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

• fast/js/kde/RegExp-expected.txt:
• fast/js/kde/script-tests/RegExp.js:
• fast/js/script-tests/regexp-compile.js:
• fast/regex/non-pattern-characters-expected.txt:

File:

• trunk/JavaScriptCore/runtime/RegExpPrototype.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/RegExpPrototype.cpp

@@ -115 +115 @@
     if (asRegExpObject(thisValue)->get(exec, exec->propertyNames().multiline).toBoolean(exec))
         postfix[index] = 'm';
-    
-    return jsNontrivialString(exec, makeString("/", asRegExpObject(thisValue)->get(exec, exec->propertyNames().source).toString(exec), postfix));
+    UString source = asRegExpObject(thisValue)->get(exec, exec->propertyNames().source).toString(exec);
+    return jsNontrivialString(exec, makeString("/", source.size() ? source : UString("(?:)"), postfix));
 }