Changeset 53062 in webkit for trunk/JavaScriptCore/tests

Timestamp:

Jan 10, 2010, 8:55:26 PM (15 years ago)

Author:

[email protected]

Message:

2010-01-10 Kent Hansen <​[email protected]>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

• runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

• tests/mozilla/ecma_2/RegExp/properties-001.js: (AddRegExpCases):
• tests/mozilla/js1_2/regexp/toString.js: Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).

2010-01-10 Kent Hansen <​[email protected]>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
​https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

• fast/js/kde/RegExp-expected.txt:
• fast/js/kde/script-tests/RegExp.js:
• fast/js/regexp-compile-expected.txt:
• fast/js/script-tests/regexp-compile.js:
• fast/regex/non-pattern-characters-expected.txt:

Location:

trunk/JavaScriptCore/tests/mozilla

Files:

• ecma_2/RegExp/properties-001.js (modified) (1 diff)
• js1_2/regexp/toString.js (modified) (1 diff)

trunk/JavaScriptCore/tests/mozilla/ecma_2/RegExp/properties-001.js

@@ -57 +57 @@
                  re.source );
 
+/*
+ * http://bugzilla.mozilla.org/show_bug.cgi?id=225550 changed
+ * the behavior of toString() and toSource() on empty regexps.
+ * So branch if |s| is the empty string -
+ */
+    var S = s? s : '(?:)';
+
     AddTestCase( re + ".toString()",
-                 "/" + s +"/" + (g?"g":"") + (i?"i":"") +(m?"m":""),
+                 "/" + S +"/" + (g?"g":"") + (i?"i":"") +(m?"m":""),
                  re.toString() );
 

trunk/JavaScriptCore/tests/mozilla/js1_2/regexp/toString.js

@@ -42 +42 @@
         var re = new RegExp();
         testcases[count++] = new TestCase ( SECTION, "var re = new RegExp(); re.toString()",
-                                            '//', re.toString());
+                                            '/(?:)/', re.toString());
 
     // re = /.+/; re.toString();