Changeset 5315 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Oct 30, 2003, 12:59:16 PM (22 years ago)

Author:

mjs

Message:

Reviewed by NOBODY (OOPS!).

• fixed 3427069 - browsing mp3.com causes leaks (KJS)

• kjs/string_object.cpp: (StringProtoFuncImp::call): Don't do an early return, since that could leak a temporary regexp.

File:

• trunk/JavaScriptCore/kjs/string_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/string_object.cpp

@@ -277 +277 @@
       if ((reg->flags() & RegExp::Global) == 0) {
         // case without 'g' flag is handled like RegExp.prototype.exec
-        if (mstr.isNull())
-          return Null(); // no match
-        regExpObj->setSubPatterns(reg->subPatterns());
-        result = regExpObj->arrayOfMatches(exec,mstr);
+        if (mstr.isNull()) {
+          result = Null();
+        } else {
+          regExpObj->setSubPatterns(reg->subPatterns());
+          result = regExpObj->arrayOfMatches(exec,mstr);
+        }
       } else {
         // return array of matches