Changeset 53437 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Jan 18, 2010, 4:02:40 PM (15 years ago)

Author:

Darin Adler

Message:

Add some ALWAYS_INLINE for key functions not inlined by some versions of GCC.
rdar://problem/7553780

Patch by Evan Cheng <​[email protected]> on 2010-01-18
Reviewed by Darin Adler.

• runtime/JSObject.h:

(JSC::JSObject::getPropertySlot): ALWAYS_INLINE both overloads.

• runtime/JSString.h:

(JSC::JSString::JSString): ALWAYS_INLINE the version that takes a UString.

• runtime/UString.h:

(JSC::operator==): ALWAYS_INLINE the version that compares two UString objects.

Location:

trunk/JavaScriptCore/runtime

Files:

• JSObject.h (modified) (2 diffs)
• JSString.h (modified) (1 diff)
• UString.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSObject.h

@@ -382 +382 @@
 // It may seem crazy to inline a function this large but it makes a big difference
 // since this is function very hot in variable lookup
-inline bool JSObject::getPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
+ALWAYS_INLINE bool JSObject::getPropertySlot(ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
 {
     JSObject* object = this;
@@ -395 +395 @@
 }
 
-inline bool JSObject::getPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
+ALWAYS_INLINE bool JSObject::getPropertySlot(ExecState* exec, unsigned propertyName, PropertySlot& slot)
 {
     JSObject* object = this;

trunk/JavaScriptCore/runtime/JSString.h

@@ -166 +166 @@
         };
 
-        JSString(JSGlobalData* globalData, const UString& value)
+        ALWAYS_INLINE JSString(JSGlobalData* globalData, const UString& value)
             : JSCell(globalData->stringStructure.get())
             , m_stringLength(value.size())

trunk/JavaScriptCore/runtime/UString.h

@@ -207 +207 @@
     };
 
-    inline bool operator==(const UString& s1, const UString& s2)
+    ALWAYS_INLINE bool operator==(const UString& s1, const UString& s2)
     {
         int size = s1.size();