Changeset 53657 in webkit for trunk/JavaScriptCore/API/tests/testapi.js

Timestamp:

Jan 21, 2010, 4:06:00 PM (15 years ago)

Author:

[email protected]

Message:

2010-01-21 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Always create a prototype for automatically managed classes.

This fixes some errors where prototype chains were not correctly hooked
up, and also ensures that API classes work correctly with features like
instanceof.

• API/JSClassRef.cpp: (OpaqueJSClass::create): Cleaned up some of this code. Also changed it to always create a prototype class.

• API/tests/testapi.c: (Derived2_class): (main): Fixed a null value crash in the exception checking code.
• API/tests/testapi.js: Added some tests for the case where a prototype chain would not be hooked up correctly.

File:

• trunk/JavaScriptCore/API/tests/testapi.js (modified) (2 diffs)

trunk/JavaScriptCore/API/tests/testapi.js

@@ -170 +170 @@
 derived = new Derived();
 
+shouldBe("derived instanceof Derived", true);
+shouldBe("derived instanceof Base", true);
+
 // base properties and functions return 1 when called/gotten; derived, 2
 shouldBe("derived.baseProtoDup()", 2);
@@ -184 +187 @@
 shouldBe("derived.derivedOnly = 0", 2)
 shouldBe("derived.protoDup = 0", 2);
+
+derived2 = new Derived2();
+
+shouldBe("derived2 instanceof Derived2", true);
+shouldBe("derived2 instanceof Derived", true);
+shouldBe("derived2 instanceof Base", true);
+
+// base properties and functions return 1 when called/gotten; derived, 2
+shouldBe("derived2.baseProtoDup()", 2);
+shouldBe("derived2.baseProto()", 1);
+shouldBe("derived2.baseDup", 2);
+shouldBe("derived2.baseOnly", 1);
+shouldBe("derived2.protoOnly()", 2);
+shouldBe("derived2.protoDup", 2);
+shouldBe("derived2.derivedOnly", 2)
+
+// base properties throw 1 when set; derived, 2
+shouldBe("derived2.baseDup = 0", 2);
+shouldBe("derived2.baseOnly = 0", 1);
+shouldBe("derived2.derivedOnly = 0", 2)
+shouldBe("derived2.protoDup = 0", 2);
 
 shouldBe('Object.getOwnPropertyDescriptor(derived, "baseProto")', undefined);