Changeset 5480 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Nov 13, 2003, 2:53:00 PM (22 years ago)

Author:

mjs

Message:

Reviewed by John.

• fixed 3472562 - Null or Undefined variables passed to IN operator cause javascript exceptions

• kjs/nodes.cpp: (ForInNode::execute): If the in value is null or undefined, bail out early, since attempting to iterate its properties will throw an exception.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -2074 +2074 @@
 
   e = expr->evaluate(exec);
+
+  // for Null and Undefined, we want to make sure not to go through
+  // the loop at all, because their object wrappers will have a
+  // property list but will throw an exception if you attempt to
+  // access any property.
+  if (e.type() == UndefinedType || e.type() == NullType) {
+    return Completion(Normal, retval);
+  }
+
   KJS_CHECKEXCEPTION
   v = e.toObject(exec);