Changeset 55043 in webkit for trunk/JavaScriptCore/Configurations

Timestamp:

Feb 19, 2010, 7:06:28 PM (15 years ago)

Author:

[email protected]

Message:

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

• Configurations/FeatureDefines.xcconfig:

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

• win/tools/vsprops/FeatureDefines.vsprops:

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

• features.gypi:

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

• Configurations/FeatureDefines.xcconfig:

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.

• Configurations/FeatureDefines.xcconfig:
• GNUmakefile.am:
• WebCore.pri:
• html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute):

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

• configure.ac:

2010-02-19 Maciej Stachowiak <​[email protected]>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
​https://bugs.webkit.org/show_bug.cgi?id=35147

• Scripts/build-webkit: Handle new flag.

File:

• trunk/JavaScriptCore/Configurations/FeatureDefines.xcconfig (modified) (2 diffs)

trunk/JavaScriptCore/Configurations/FeatureDefines.xcconfig

@@ -58 +58 @@
 ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS;
 ENABLE_RUBY = ENABLE_RUBY;
+ENABLE_SANDBOX = ENABLE_SANDBOX;
 ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS;
 ENABLE_SVG = ENABLE_SVG;
@@ -74 +75 @@
 ENABLE_XSLT = ENABLE_XSLT;
 
-FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_SANDBOX) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);