Changeset 58220 in webkit for trunk/JavaScriptCore

Timestamp:

Apr 24, 2010, 10:53:24 AM (15 years ago)

Author:

[email protected]

Message:

2010-04-24 Anton Muhin <​[email protected]>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
​https://bugs.webkit.org/show_bug.cgi?id=37722

• wtf/RefPtr.h: expose hash table deleted value

2010-04-24 Anton Muhin <​[email protected]>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
​https://bugs.webkit.org/show_bug.cgi?id=37722

• dom/QualifiedName.cpp: (WebCore::QualifiedName::deref): check that hash table deleted values never derefed
• dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values (WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value (WTF::):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/RefPtr.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-04-24  Anton Muhin  <[email protected]>
+
+        Reviewed by Darin Adler.
+
+        Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue
+
+        Former implementation attempted to use AtomicString(HashTableDeletedValue)
+        however those values cannot be used that way: one cannot construct
+        QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
+        in the table, for example.
+        https://bugs.webkit.org/show_bug.cgi?id=37722
+
+        * wtf/RefPtr.h: expose hash table deleted value
+
 2010-04-23  Sam Weinig  <[email protected]>
 

trunk/JavaScriptCore/wtf/RefPtr.h

@@ -80 +80 @@
         void swap(RefPtr&);
 
+        static T* hashTableDeletedValue() { return reinterpret_cast<T*>(-1); }
+
     private:
-        static T* hashTableDeletedValue() { return reinterpret_cast<T*>(-1); }
-
         T* m_ptr;
     };