Changeset 58755 in webkit for trunk/JavaScriptCore/qt

Timestamp:

May 4, 2010, 6:53:57 AM (15 years ago)

Author:

[email protected]

Message:

2010-05-04 Jedrzej Nowacki <​[email protected]>

Reviewed by Holger Freyther.

Fix a memory leak inside the QScriptValue.

QSciptValuePrivate::toString should release all temporary variables.

[Qt] QScriptValue::toString have a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=38112

• qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):

File:

• trunk/JavaScriptCore/qt/api/qscriptvalue_p.h (modified) (2 diffs)

trunk/JavaScriptCore/qt/api/qscriptvalue_p.h

@@ -25 +25 @@
 #include "qscriptvalue.h"
 #include <JavaScriptCore/JavaScript.h>
+#include <JavaScriptCore/JSRetainPtr.h>
 #include <QtCore/qmath.h>
 #include <QtCore/qnumeric.h>
@@ -425 +426 @@
     case JSPrimitive:
     case JSObject:
-        return QScriptConverter::toString(JSValueToStringCopy(context(), value(), /* exception */ 0));
+        JSRetainPtr<JSStringRef> ptr(Adopt, JSValueToStringCopy(context(), value(), /* exception */ 0));
+        return QScriptConverter::toString(ptr.get());
     }