Changeset 58885 in webkit for trunk/JavaScriptCore

Timestamp:

May 6, 2010, 9:32:42 AM (15 years ago)

Author:

Martin Robinson

Message:

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

• wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

No new tests, because functionality has not changed.

• page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
• platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here. (WebCore::ClipboardGtk::helper): Added. (WebCore::ClipboardGtk::dataObject): Added.
• platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

• WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op. (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
• WebCoreSupport/DragClientGtk.h: Small style fix.
• webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
• webkit/webkitwebview.cpp: (webkit_web_view_dispose): Clear all data objects during disposal. (webkit_web_view_drag_end): When a drag is over, just remove it from the map. (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/gobject/GRefPtr.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-05-06  Martin Robinson  <[email protected]>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] Enable DOM clipboard and drag-and-drop access
+        https://bugs.webkit.org/show_bug.cgi?id=30623
+
+        Convert dragging portion of drag-and-drop to use DataObjectGtk.
+
+        * wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.
+
 2010-05-06  Steve Block  <[email protected]>
 

trunk/JavaScriptCore/wtf/gobject/GRefPtr.h

@@ -28 +28 @@
 
 typedef struct _GHashTable GHashTable;
+typedef void* gpointer;
+extern "C" void g_object_unref(gpointer object);
+extern "C" gpointer  g_object_ref_sink(gpointer object);
 
 namespace WTF {