Changeset 59055 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

May 9, 2010, 4:18:25 AM (15 years ago)

Author:

[email protected]

Message:

2010-05-09 Maciej Stachowiak <​[email protected]>

Fixed version of: "Optimized o[s] where o is a cell and s is a string"
​https://bugs.webkit.org/show_bug.cgi?id=38815

Fixed the previous patch for this from Geoff Garen.

The two problems were a missing exception check and a PropertySlot
initialized improperly, leading to crashes and failures in the case
of getters accessed with bracket syntax.

Previous patch:

Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.

SunSpider says 0.8% faster.

• jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
• runtime/JSCell.h:

File:

• trunk/JavaScriptCore/runtime/JSCell.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/JSCell.h

@@ -112 +112 @@
         void setVPtr(void* vptr) { *reinterpret_cast<void**>(this) = vptr; }
 
+        // FIXME: Rename getOwnPropertySlot to virtualGetOwnPropertySlot, and
+        // fastGetOwnPropertySlot to getOwnPropertySlot. Callers should always
+        // call this function, not its slower virtual counterpart. (For integer
+        // property names, we want a similar interface with appropriate optimizations.)
+        bool fastGetOwnPropertySlot(ExecState*, const Identifier& propertyName, PropertySlot&);
+
     protected:
         static const unsigned AnonymousSlotCount = 0;
@@ -117 +123 @@
     private:
         // Base implementation; for non-object classes implements getPropertySlot.
-        bool fastGetOwnPropertySlot(ExecState*, const Identifier& propertyName, PropertySlot&);
         virtual bool getOwnPropertySlot(ExecState*, const Identifier& propertyName, PropertySlot&);
         virtual bool getOwnPropertySlot(ExecState*, unsigned propertyName, PropertySlot&);