Changeset 59222 in webkit for trunk/JavaScriptCore/yarr

Timestamp:

May 12, 2010, 4:49:40 AM (15 years ago)

Author:

[email protected]

Message:

2010-05-12 Peter Varga <​[email protected]>

Reviewed by Gavin Barraclough.

Remove a direct jump in generatePatternCharacterGreedy() and
generatePatternCharacterClassGreedy() functions if quantityCount of the term
is unlimited.
​https://bugs.webkit.org/show_bug.cgi?id=38898

• yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):

File:

• trunk/JavaScriptCore/yarr/RegexJIT.cpp (modified) (2 diffs)

trunk/JavaScriptCore/yarr/RegexJIT.cpp

@@ -617 +617 @@
         add32(Imm32(1), countRegister);
         add32(Imm32(1), index);
-        if (term.quantityCount != 0xffffffff)
+        if (term.quantityCount != 0xffffffff) {
             branch32(NotEqual, countRegister, Imm32(term.quantityCount)).linkTo(loop, this);
-        else
+            failures.append(jump());
+        } else
             jump(loop);
-
-        failures.append(jump());
 
         Label backtrackBegin(this);
@@ -743 +742 @@
         add32(Imm32(1), countRegister);
         add32(Imm32(1), index);
-        if (term.quantityCount != 0xffffffff)
+        if (term.quantityCount != 0xffffffff) {
             branch32(NotEqual, countRegister, Imm32(term.quantityCount)).linkTo(loop, this);
-        else
+            failures.append(jump());
+        } else
             jump(loop);
-
-        failures.append(jump());
 
         Label backtrackBegin(this);