Changeset 61946 in webkit for trunk/JavaScriptCore

Timestamp:

Jun 25, 2010, 11:25:46 PM (15 years ago)

Author:

[email protected]

Message:

2010-06-25 Nathan Lawrence <​[email protected]>

Reviewed by Geoffrey Garen.

We assume in testapi.c that the value aHeapRef refers to will not be
moved. When we have movable objects, this will not be the case.

• API/tests/testapi.c: (main):

Location:

trunk/JavaScriptCore

Files:

• API/tests/testapi.c (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/JavaScriptCore/API/tests/testapi.c

@@ -928 +928 @@
     
     JSStringRef lengthStr = JSStringCreateWithUTF8CString("length");
-    aHeapRef = JSObjectMakeArray(context, 0, 0, 0);
+    JSObjectRef aStackRef = JSObjectMakeArray(context, 0, 0, 0);
+    aHeapRef = aStackRef;
     JSObjectSetProperty(context, aHeapRef, lengthStr, JSValueMakeNumber(context, 10), 0, 0);
     JSStringRef privatePropertyName = JSStringCreateWithUTF8CString("privateProperty");
@@ -937 +938 @@
         printf("PASS: Set private property.\n");
     }
+    aStackRef = 0;
     if (JSObjectSetPrivateProperty(context, aHeapRef, privatePropertyName, aHeapRef)) {
         printf("FAIL: JSObjectSetPrivateProperty should fail on non-API objects.\n");
@@ -965 +967 @@
         JSObjectMake(context, 0, 0);
 
+    aHeapRef = JSValueToObject(context, JSObjectGetPrivateProperty(context, myObject, privatePropertyName), 0);
     if (JSValueToNumber(context, JSObjectGetProperty(context, aHeapRef, lengthStr, 0), 0) != 10) {
         printf("FAIL: Private property has been collected.\n");

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-06-25  Nathan Lawrence  <[email protected]>
+
+        Reviewed by Geoffrey Garen.
+
+        We assume in testapi.c that the value aHeapRef refers to will not be
+        moved.  When we have movable objects, this will not be the case.
+
+        * API/tests/testapi.c:
+        (main):
+
 2010-06-25  Sheriff Bot  <[email protected]>