Changeset 65266 in webkit for trunk/JavaScriptCore

Timestamp:

Aug 12, 2010, 2:20:06 PM (15 years ago)

Author:

[email protected]

Message:

Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
This appears to have degraded performance.

Reviewed by Sam Weinig

• runtime/UString.cpp:

(JSC::UString::ascii):

• runtime/UString.h:

(JSC::UString::length):
(JSC::UString::isEmpty):
(JSC::UString::~UString):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/UString.cpp (modified) (1 diff)
• runtime/UString.h (modified) (4 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-08-12  Gavin Barraclough  <[email protected]>
+
+        Reviewed by Sam Weinig
+
+        Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
+        This appears to have degraded performance.
+
+        * runtime/UString.cpp:
+        (JSC::UString::ascii):
+        * runtime/UString.h:
+        (JSC::UString::length):
+        (JSC::UString::isEmpty):
+        (JSC::UString::~UString):
+
 2010-08-12  Csaba Osztrogonác  <[email protected]>
 

trunk/JavaScriptCore/runtime/UString.cpp

@@ -198 +198 @@
     asciiBuffer = new char[neededSize];
 
-    const UChar* p = characters(); // Don't roll me out!
+    const UChar* p = characters();
     char* q = asciiBuffer;
     const UChar* limit = p + len;

trunk/JavaScriptCore/runtime/UString.h

@@ -87 +87 @@
     CString UTF8String(bool strict = false) const;
 
-    ALWAYS_INLINE unsigned length() const
+    unsigned length() const
     {
         if (!m_impl)
@@ -122 +122 @@
 
     bool isNull() const { return !m_impl; }
-    ALWAYS_INLINE bool isEmpty() const { return !m_impl || !m_impl->length(); }
+    bool isEmpty() const { return !m_impl || !m_impl->length(); }
 
     StringImpl* impl() const { return m_impl.get(); }
@@ -138 +138 @@
     }
 
+    ALWAYS_INLINE ~UString() { }
 private:
     RefPtr<StringImpl> m_impl;
@@ -267 +268 @@
 
 #endif
+
+#include "StringConcatenate.h"