Changeset 65311 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Aug 13, 2010, 3:14:36 AM (15 years ago)

Author:

[email protected]

Message:

Avoid increasing required alignment of target type warning on ARM
​https://bugs.webkit.org/show_bug.cgi?id=38045

Reviewed by Gavin Barraclough.

The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
increases required alignment of target type warnings.
Casting the type of [pointer to Type2] object to void* bypasses the
warning.

• JavaScriptCore/assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

• JavaScriptCore/assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt64Unchecked):

• JavaScriptCore/interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):

• JavaScriptCore/jit/JITStubs.cpp:
• JavaScriptCore/pcre/pcre_compile.cpp:

(jsRegExpCompile):

• JavaScriptCore/runtime/JSArray.cpp:

(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

• JavaScriptCore/wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::New):
(WTF::TCMalloc_Central_FreeList::Populate):

• wtf/MD5.cpp:

(WTF::reverseBytes):
(WTF::MD5::addBytes):
(WTF::MD5::checksum):

• JavaScriptCore/wtf/StdLibExtras.h:

(isPointerTypeAlignmentOkay):
(reinterpret_cast_ptr):

• JavaScriptCore/wtf/Vector.h:

(WTF::VectorBuffer::inlineBuffer):

• JavaScriptCore/wtf/qt/StringQt.cpp:

(WTF::String::String):

File:

• trunk/JavaScriptCore/runtime/JSArray.cpp (modified) (5 diffs)

trunk/JavaScriptCore/runtime/JSArray.cpp

@@ -442 +442 @@
     }
 
-    m_storage = reinterpret_cast<ArrayStorage*>(static_cast<char*>(baseStorage) + m_indexBias * sizeof(JSValue));
+    m_storage = reinterpret_cast_ptr<ArrayStorage*>(static_cast<char*>(baseStorage) + m_indexBias * sizeof(JSValue));
     m_storage->m_allocBase = baseStorage;
     storage = m_storage;
@@ -592 +592 @@
         return false;
 
-    storage = m_storage = reinterpret_cast<ArrayStorage*>(static_cast<char*>(baseStorage) + m_indexBias * sizeof(JSValue));
+    storage = m_storage = reinterpret_cast_ptr<ArrayStorage*>(static_cast<char*>(baseStorage) + m_indexBias * sizeof(JSValue));
     m_storage->m_allocBase = baseStorage;
 
@@ -624 +624 @@
     m_indexBias += newVectorLength - newLength;
     
-    m_storage = reinterpret_cast<ArrayStorage*>(static_cast<char*>(newBaseStorage) + m_indexBias * sizeof(JSValue));
+    m_storage = reinterpret_cast_ptr<ArrayStorage*>(static_cast<char*>(newBaseStorage) + m_indexBias * sizeof(JSValue));
 
     memcpy(m_storage, storage, storageSize(0));
@@ -803 +803 @@
             char* newBaseStorage = reinterpret_cast<char*>(storage) + count * sizeof(JSValue);
             memmove(newBaseStorage, storage, storageSize(0));
-            m_storage = reinterpret_cast<ArrayStorage*>(newBaseStorage);
+            m_storage = reinterpret_cast_ptr<ArrayStorage*>(newBaseStorage);
 
             m_indexBias += count;
@@ -840 +840 @@
         char* newBaseStorage = reinterpret_cast<char*>(storage) - count * sizeof(JSValue);
         memmove(newBaseStorage, storage, storageSize(0));
-        m_storage = reinterpret_cast<ArrayStorage*>(newBaseStorage);
+        m_storage = reinterpret_cast_ptr<ArrayStorage*>(newBaseStorage);
         m_vectorLength += count;
     } else if (!increaseVectorPrefixLength(m_vectorLength + count)) {