Changeset 67066 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 8, 2010, 11:53:33 PM (15 years ago)

Author:

[email protected]

Message:

Removing doneSemicolon label in the lexer
​https://bugs.webkit.org/show_bug.cgi?id=45289

Reviewed by Darin Adler.

As a side effect of moving the multiline comment parsing
to a separate function, an opportunity raised to simplify
the single line comment parsing, and removing doneSemicolon
label. Slight performance increase on --parse-only
tests (from 32.8ms to 31.5ms)

• parser/Lexer.cpp:

(JSC::Lexer::lex):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• parser/Lexer.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-09-08  Zoltan Herczeg  <[email protected]>
+
+        Reviewed by Darin Adler.
+
+        Removing doneSemicolon label in the lexer
+        https://bugs.webkit.org/show_bug.cgi?id=45289
+
+        As a side effect of moving the multiline comment parsing
+        to a separate function, an opportunity raised to simplify
+        the single line comment parsing, and removing doneSemicolon
+        label. Slight performance increase on --parse-only
+        tests (from 32.8ms to 31.5ms)
+
+        * parser/Lexer.cpp:
+        (JSC::Lexer::lex):
+
 2010-09-08  Xan Lopez  <[email protected]>
 

trunk/JavaScriptCore/parser/Lexer.cpp

@@ -1026 +1026 @@
         if (lastTokenWasRestrKeyword()) {
             token = SEMICOLON;
-            goto doneSemicolon;
+            m_delimited = true;
+            goto returnToken;
         }
         goto start;
@@ -1048 +1049 @@
     m_atLineStart = true;
     m_terminator = true;
-    if (lastTokenWasRestrKeyword())
-        goto doneSemicolon;
-    goto start;
-
-doneSemicolon:
+    if (!lastTokenWasRestrKeyword())
+        goto start;
+
     token = SEMICOLON;
     m_delimited = true;
     // Fall through into returnToken.
 
-returnToken: {
-    int lineNumber = m_lineNumber;
-    llocp->line = lineNumber;
+returnToken:
+    llocp->line = m_lineNumber;
     llocp->startOffset = startOffset;
     llocp->endOffset = currentOffset();
     m_lastToken = token;
     return token;
-}
 
 returnError: