Changeset 88587 in webkit for trunk/Source/JavaScriptCore/API

Timestamp:

Jun 10, 2011, 7:03:00 PM (14 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf

Reviewed by Sam Weinig.

There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.

Remove JSC::Inf, JSC::NaN, switch some cases of (isnan

isinf) to !isfinite.

Source/JavaScriptCore:

• API/JSCallbackObjectFunctions.h:

(JSC::::toNumber):

• API/JSValueRef.cpp:

(JSValueMakeNumber):
(JSValueToNumber):

• JavaScriptCore.exp:
• runtime/CachedTranscendentalFunction.h:

(JSC::CachedTranscendentalFunction::initialize):

• runtime/DateConstructor.cpp:

(JSC::constructDate):

• runtime/DateInstanceCache.h:

(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):

• runtime/JSCell.cpp:
• runtime/JSCell.h:

(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):

• runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toNumber):

• runtime/JSValue.cpp:
• runtime/JSValue.h:
• runtime/JSValueInlineMethods.h:

(JSC::jsNaN):

• runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

• runtime/NumberConstructor.cpp:

(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):

• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

• runtime/UString.cpp:
• wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

• wtf/dtoa.cpp:

(WTF::dtoa):

Source/WebCore:

• bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

Location:

trunk/Source/JavaScriptCore/API

Files:

• JSCallbackObjectFunctions.h (modified) (2 diffs)
• JSValueRef.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/JSCallbackObjectFunctions.h

@@ -445 +445 @@
     // primitive
     if (exec->hadException())
-        return NaN;
+        return std::numeric_limits<double>::quiet_NaN();
     JSContextRef ctx = toRef(exec);
     JSObjectRef thisRef = toRef(this);
@@ -464 +464 @@
             double dValue;
             if (value)
-                return toJS(exec, value).getNumber(dValue) ? dValue : NaN;
+                return toJS(exec, value).getNumber(dValue) ? dValue : std::numeric_limits<double>::quiet_NaN();
         }
             

trunk/Source/JavaScriptCore/API/JSValueRef.cpp

@@ -218 +218 @@
     // but an external NaN might not.
     if (isnan(value))
-        value = NaN;
+        value = std::numeric_limits<double>::quiet_NaN();
 
     return toRef(exec, jsNumber(value));
@@ -277 +277 @@
             *exception = toRef(exec, exec->exception());
         exec->clearException();
-        number = NaN;
+        number = std::numeric_limits<double>::quiet_NaN();
     }
     return number;