Changeset 8904 in webkit for trunk/JavaScriptCore

Timestamp:

Mar 16, 2005, 10:30:25 AM (20 years ago)

Author:

jens

Message:

[4025212] search not performed correctly; united.com. Fixed bug inherited from KJS that caused unescape() of an empty string to return a messed-up String object that would sometimes act like the value 'null'.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/function.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2005-03-16  Jens Alfke  <[email protected]>
+
+        Reviewed by Kevin.
+
+        Fix for <rdar://problem/4025212> "REGRESSION (163-164): search not performed correctly; united.com"
+        JavaScript unescape("") was returning a messed-up String object that appeared identical to an empty string, but would in some cases act as 'null' when passed to native functions, in this case the Option() constructor.
+        In the implementation of unescape, the UString holding the result was not initialized to "", so it started out as a null string. If nothing was appended to it, it remained null, resulting in a JavaScript String object with some bad behaviors (namely, converting it to a DOMStringImpl results in a NULL pointer.)
+        Darin says this regression occurred when we replaced our own implementation of unescape() with code from KJS.
+
+        * kjs/function.cpp:
+        (KJS::GlobalFuncImp::call):
+
 2005-03-15  Richard Williamson   <[email protected]>
 

trunk/JavaScriptCore/kjs/function.cpp

@@ -735 +735 @@
   case UnEscape:
     {
-      UString s, str = args[0].toString(exec);
+      UString s = "", str = args[0].toString(exec);
       int k = 0, len = str.size();
       while (k < len) {