Changeset 93017 in webkit for trunk/Source/JavaScriptCore/API

Timestamp:

Aug 13, 2011, 10:48:53 AM (14 years ago)

Author:

[email protected]

Message:

Fix a bunch of minor bugs caught by the clang static analyzer in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=66182

Reviewed by Dan Bernstein.

Fixes 10 warnings in JavaScriptCore and 2 in testapi.

• API/tests/testapi.c:

(main):
Remove dead variables.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
Initialize hasPrinted and silence an unused warning by casting to void (Ok here
since it is debug code and I want to keep it clear that if other cases are added,
the hasPrinted flag would be needed).

• wtf/dtoa.cpp:

(WTF::d2b):
The variable "de" in the else block is always zero, so there is no reason to
use it.

File:

• trunk/Source/JavaScriptCore/API/tests/testapi.c (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/tests/testapi.c

@@ -1367 +1367 @@
     ASSERT(function && !exception);
     JSValueRef arguments[] = { JSValueMakeNumber(context, 2) };
-    v = JSObjectCallAsFunction(context, function, NULL, 1, arguments, &exception);
+    JSObjectCallAsFunction(context, function, NULL, 1, arguments, &exception);
     JSStringRelease(foo);
     JSStringRelease(functionBody);
@@ -1494 +1494 @@
     nullDefinition = kJSClassDefinitionEmpty;
     nullClass = JSClassCreate(&nullDefinition);
-    myConstructor = JSObjectMakeConstructor(context, nullClass, 0);
+    JSObjectMakeConstructor(context, nullClass, 0);
     JSClassRelease(nullClass);