Changeset 94802 in webkit for trunk/Source/JavaScriptCore/dfg

Timestamp:

Sep 8, 2011, 2:38:04 PM (14 years ago)

Author:

[email protected]

Message:

Value profling and execution count profiling is performed even for
code that cannot be optimized
​https://bugs.webkit.org/show_bug.cgi?id=67694

Reviewed by Gavin Barraclough.

This is a 2% speed-up on V8 when tiered compilation is enabled.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/CodeBlock.cpp:

(JSC::ProgramCodeBlock::canCompileWithDFG):
(JSC::EvalCodeBlock::canCompileWithDFG):
(JSC::FunctionCodeBlock::canCompileWithDFG):

• bytecode/CodeBlock.h:
• dfg/DFGCapabilities.cpp: Added.

(JSC::DFG::canCompileOpcodes):

• dfg/DFGCapabilities.h: Added.

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):

• jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompile):

• jit/JIT.h:

(JSC::JIT::shouldEmitProfiling):

• jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

Location:

trunk/Source/JavaScriptCore/dfg

Files:

• DFGByteCodeParser.cpp (modified) (3 diffs)
• DFGCapabilities.cpp (added)
• DFGCapabilities.h (added)

trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

@@ -30 +30 @@
 
 #include "DFGAliasTracker.h"
+#include "DFGCapabilities.h"
 #include "DFGScoreBoard.h"
 #include "CodeBlock.h"
@@ -599 +600 @@
         // Switch on the current bytecode opcode.
         Instruction* currentInstruction = instructionsBegin + m_currentIndex;
-        switch (interpreter->getOpcodeID(currentInstruction->u.opcode)) {
+        OpcodeID opcodeID = interpreter->getOpcodeID(currentInstruction->u.opcode);
+        switch (opcodeID) {
 
         // === Function entry opcodes ===
@@ -1209 +1211 @@
         default:
             // Parse failed!
+            ASSERT(!canCompileOpcode(opcodeID));
             return false;
         }
+        
+        ASSERT(canCompileOpcode(opcodeID));
     }
 }