Changeset 96881 in webkit for trunk/Source/JavaScriptCore/wtf

Timestamp:

Oct 6, 2011, 5:34:05 PM (14 years ago)

Author:

[email protected]

Message:

When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
​https://bugs.webkit.org/show_bug.cgi?id=69586

Reviewed by Darin Adler.

../JavaScriptCore:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• JavaScriptCore.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

• jsc.cpp:

(runInteractive):
Move interpreterName into runInteractive.

• wtf/StdLibExtras.h:

When building with clang, disable the -Wglobal-constructors and -Wexit-time-destructors
warnings around the variable declaration.

../JavaScriptGlue:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• JavaScriptGlue.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebCore:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• WebCore.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

• platform/graphics/filters/FEGaussianBlur.cpp:

(gaussianKernelFactor):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):
Change the gaussian kernel factor global to be an inline function instead.

../WebKit:

• WebKit.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

../WebKit/mac:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

../WebKit2:

• Configurations/Base.xcconfig:

Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.

• WebKit2.xcodeproj/project.pbxproj:

When building with clang, we don't need to run the check-for-global-initializers and
check-for-exit-time-destructors anymore.

File:

• trunk/Source/JavaScriptCore/wtf/StdLibExtras.h (modified) (1 diff)

trunk/Source/JavaScriptCore/wtf/StdLibExtras.h

@@ -45 +45 @@
 
 // Use this macro to declare and define a debug-only global variable that may have a
-// non-trivial constructor and destructor.
+// non-trivial constructor and destructor. When building with clang, this will suppress
+// warnings about global constructors and exit-time destructors.
 #ifndef NDEBUG
+#if COMPILER(CLANG)
+#define DEFINE_DEBUG_ONLY_GLOBAL(type, name, arguments) \
+    _Pragma("clang diagnostic push") \
+    _Pragma("clang diagnostic ignored \"-Wglobal-constructors\"") \
+    _Pragma("clang diagnostic ignored \"-Wexit-time-destructors\"") \
+    static type name arguments; \
+    _Pragma("clang diagnostic pop")
+#else
 #define DEFINE_DEBUG_ONLY_GLOBAL(type, name, arguments) \
     static type name arguments;
+#endif // COMPILER(CLANG)
 #else
 #define DEFINE_DEBUG_ONLY_GLOBAL(type, name, arguments)