Changeset 98123 in webkit for trunk/Source/JavaScriptCore/heap

Timestamp:

Oct 21, 2011, 12:36:46 PM (14 years ago)

Author:

[email protected]

Message:

Add finalizer to JSObject
​https://bugs.webkit.org/show_bug.cgi?id=70336

Reviewed by Darin Adler.

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor): Skip the call to the destructor
if we're a JSFinalObject, since the finalizer takes care of things.

• runtime/JSCell.h:

(JSC::JSCell::~JSCell): Remove the GC validation due to a conflict with
future changes and the fact that we no longer always call the destructor, making
the information provided less useful.

• runtime/JSObject.cpp:

(JSC::JSObject::finalize): Add finalizer for JSObject.
(JSC::JSObject::allocatePropertyStorage): The first time we need to allocate out-of-line
property storage, we add a finalizer to ourself.

• runtime/JSObject.h:

File:

• trunk/Source/JavaScriptCore/heap/MarkedBlock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/MarkedBlock.cpp

@@ -71 +71 @@
     m_heap->m_destroyedTypeCounts.countVPtr(vptr);
 #endif
-    if (vptr == jsFinalObjectVPtr)
-        reinterpret_cast<JSFinalObject*>(cell)->JSFinalObject::~JSFinalObject();
-    else
+    if (vptr != jsFinalObjectVPtr)
         cell->~JSCell();