Re: Add support for (Var op Var) clause in extended MCV statistics - Mailing list pgsql-hackers

From Alena Rybakina
Subject Re: Add support for (Var op Var) clause in extended MCV statistics
Date
Msg-id [email protected]
Whole thread Raw
In response to Add support for (Var op Var) clause in extended MCV statistics  (Ilia Evdokimov <[email protected]>)
Responses Re: Add support for (Var op Var) clause in extended MCV statistics
List pgsql-hackers
Hi! I think your work is important)

I started reviewing it and want to suggest some changes to better code: 
I think we should consider the case where the expression is not neither 
an OpExpr and VarOpVar expression.

Have you tested this code with any benchmarks?

-- 
Regards,
Alena Rybakina
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h
Next
From: Thomas Munro
Date:
Subject: Re: Make query cancellation keys longer