Hello Ildus,
On 29.01.2018 14:44, Ildus Kurbangaliev wrote:
>
> Thanks! Attached new version of the patch.
>
Patch applies cleanly, builds without any warnings, documentation builds
ok, all tests pass.
A remark for the committers. The patch is quite big, so I really wish
more reviewers looked into it for more comprehensive review. Also a
native english speaker should check the documentation and comments.
Another thing is that tests don't cover cmdrop method because the
built-in pglz compression doesn't use it (I know there is an jsonbd
extension [1] based on this patch and which should benefit from cmdrop
method, but it doesn't test it either yet).
I think I did what I could and so passing this patch to committers for
the review. Changed status to "Ready for committer".
[1] https://github.com/postgrespro/jsonbd
--
Ildar Musin
[email protected]
