Re: 039_end_of_wal: error in "xl_tot_len zero" test - Mailing list pgsql-hackers

From Anton Voloshin
Subject Re: 039_end_of_wal: error in "xl_tot_len zero" test
Date
Msg-id [email protected]
Whole thread Raw
In response to Re: 039_end_of_wal: error in "xl_tot_len zero" test  (Thomas Munro <[email protected]>)
Responses Re: 039_end_of_wal: error in "xl_tot_len zero" test
List pgsql-hackers
Hello, Thomas,

On 19/01/2024 01:35, Thomas Munro wrote:
> I don't yet have an opinion on the best way to
> do it though.  Would it be enough to add emit_message($node, 0) after
> advance_out_of_record_splitting_zone()?

Yes, indeed that seems to be enough. At least I could not produce any 
more "xl_tot_len zero" failures with that addition.

I like this solution the best.

> Tolerating the two different messages would weaken the test.

I agree, I also don't really like this option.

-- 
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru



pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: Justin Pryzby
Date:
Subject: Re: pg_upgrade and logical replication