On 09.07.2023 13:56, Pavel Luzanov wrote:
> On 08.07.2023 20:07, Tom Lane wrote:
>> 1. I was thinking in terms of dropping the "Member of" column entirely
>> in \du and \dg. It doesn't tell you enough, and the output of those
>> commands is often too wide already.
>
>> 2. You have describeRoleGrants() set up to localize "ADMIN", "INHERIT",
>> and "SET". Since those are SQL keywords, our usual practice is to not
>> localize them; this'd simplify the code.
>
>
>> 3. Not sure about use of LEFT JOIN in the query. That will mean we
>> get a row out even for roles that have no grants, which seems like
>> clutter. The LEFT JOINs to r and g are fine, but I suggest changing
>> the first join to a plain join.
>
> So, I accepted all three suggestions. I will wait for other opinions and
> plan to implement discussed changes within a few days.
Please review the updated version with suggested changes.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
