Re: psql tab-complete - Mailing list pgsql-hackers

From Victor Spirin
Subject Re: psql tab-complete
Date
Msg-id [email protected]
Whole thread Raw
In response to Re: psql tab-complete  (Victor Spirin <[email protected]>)
Responses Re: psql tab-complete
List pgsql-hackers
This patch resolved one problem in the tab-complete.c on MSVC. The 
VA_ARGS_NARGS macros now work correctly on Windows.


Victor Spirin
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company

25.10.2019 0:53, Victor Spirin пишет:
> Yes, I found, that VA_ARGS_NARGS(__ VA_ARGS__) macros always return 1 
> on Windows.
>
> Victor Spirin
> Postgres Professional:http://www.postgrespro.com
> The Russian Postgres Company
>
> 25.10.2019 0:48, Tom Lane пишет:
>> Victor Spirin <[email protected]> writes:
>>> I found some problem with tab-complete in the 12 version.  I checked
>>> this in the Windows.
>> This change seems to break the case intended by the comment,
>> ie given the context
>>
>>     SELECT * FROM tablename WHERE <tab>
>>
>> we want to offer the columns of "tablename" as completions.
>>
>> I'd be the first to agree that that's completely lame, as there
>> are any number of related cases it fails to cover ... but this
>> patch isn't making it better.
>>
>>             regards, tom lane
>>
>>
>
>

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods
Next
From: Amit Kapila
Date:
Subject: define bool in pgtypeslib_extern.h