pg_createsubscriber: Fix an unpredictable recovery wait time.
authorAmit Kapila <[email protected]>
Tue, 30 Jul 2024 08:47:30 +0000 (14:17 +0530)
committerAmit Kapila <[email protected]>
Tue, 30 Jul 2024 08:47:30 +0000 (14:17 +0530)
commite5ba6a5ab62ce05e2a762b4d26f0fd0c52c7b521
tree69ac9c1089f559deeea622c477205a13257ef0bf
parentf95c5090d975c3f552823f1f6895193d5da19825
pg_createsubscriber: Fix an unpredictable recovery wait time.

The problem is that the tool is using the LSN returned by
pg_create_logical_replication_slot() as recovery_target_lsn. This LSN is
ahead of the current WAL position and the recovery waits until the
publisher writes a WAL record to reach the target and ends the recovery.
On idle systems, this wait time is unpredictable and could lead to failure
in promoting the subscriber. To avoid that, insert a harmless WAL record.

Reported-by: Alexander Lakhin and Tom Lane
Diagnosed-by: Hayato Kuroda
Author: Euler Taveira
Reviewed-by: Hayato Kuroda, Amit Kapila
Backpatch-through: 17
Discussion: https://postgr.es/m/2377319.1719766794%40sss.pgh.pa.us
Discussion: https://postgr.es/m/CA+TgmoYcY+Wb67NAwaHT7MvxCSeV86oSc+va9hHKaasE42ukyw@mail.gmail.com
src/bin/pg_basebackup/pg_createsubscriber.c