#47 - Fixes the issues with the test case.

[bookstack] / app / Http / Controllers / ImageController.php

diff --git a/app/Http/Controllers/ImageController.php b/app/Http/Controllers/ImageController.php
index 941f2ad39986c3062ae047306dabd957c542b066..77c320e07db7989203f87284914ba39e68803672 100644 (file)
--- a/app/Http/Controllers/ImageController.php
+++ b/app/Http/Controllers/ImageController.php
@@ -1,88 +1,177 @@
-<?php
-
-namespace Oxbow\Http\Controllers;
+<?php namespace BookStack\Http\Controllers;

 
 

+use BookStack\Exceptions\ImageUploadException;
+use BookStack\Repos\EntityRepo;
+use BookStack\Repos\ImageRepo;

 use Illuminate\Filesystem\Filesystem as File;
 use Illuminate\Http\Request;
 use Illuminate\Filesystem\Filesystem as File;
 use Illuminate\Http\Request;

-
-use Oxbow\Http\Requests;
-use Oxbow\Image;
+use BookStack\Image;
+use BookStack\Repos\PageRepo;

 
 class ImageController extends Controller
 {
     protected $image;
     protected $file;
 
 class ImageController extends Controller
 {
     protected $image;
     protected $file;

+    protected $imageRepo;

 
     /**
      * ImageController constructor.
      * @param Image $image
      * @param File $file
 
     /**
      * ImageController constructor.
      * @param Image $image
      * @param File $file

+     * @param ImageRepo $imageRepo

      */
      */

-    public function __construct(Image $image, File $file)
+    public function __construct(Image $image, File $file, ImageRepo $imageRepo)

     {
         $this->image = $image;
         $this->file = $file;
     {
         $this->image = $image;
         $this->file = $file;

+        $this->imageRepo = $imageRepo;
+        parent::__construct();

     }
 
     /**
     }
 
     /**

-     * Returns an image from behind the public-facing application.
+     * Get all images for a specific type, Paginated
+     * @param string $type
+     * @param int $page
+     * @return \Illuminate\Http\JsonResponse
+     */
+    public function getAllByType($type, $page = 0)
+    {
+        $imgData = $this->imageRepo->getPaginatedByType($type, $page);
+        return response()->json($imgData);
+    }
+
+    /**
+     * Search through images within a particular type.
+     * @param $type
+     * @param int $page

      * @param Request $request
      * @param Request $request

-     * @return \Illuminate\Http\Response
+     * @return mixed

      */
      */

-    public function getImage(Request $request)
+    public function searchByType($type, $page = 0, Request $request)

     {
     {

-        $cacheTime = 60*60*24;
-        $path = storage_path() . '/' . $request->path();
-        $modifiedTime = $this->file->lastModified($path);
-        $eTag = md5($modifiedTime . $path);
-        $headerLastModified = gmdate('r', $modifiedTime);
-        $headerExpires = gmdate('r', $modifiedTime + $cacheTime);
-
-        $headers = [
-            'Last-Modified' => $headerLastModified,
-            'Cache-Control' => 'must-revalidate',
-            'Pragma' => 'public',
-            'Expires' => $headerExpires,
-            'Etag' => $eTag
-        ];
-
-        $browserModifiedSince = $request->header('If-Modified-Since');
-        $browserNoneMatch = $request->header('If-None-Match');
-        if($browserModifiedSince !== null && file_exists($path) && ($browserModifiedSince == $headerLastModified || $browserNoneMatch == $eTag)) {
-            return response()->make('', 304, $headers);
-        }
+        $this->validate($request, [
+            'term' => 'required|string'
+        ]);

 
 

-        if(file_exists($path)) {
-            return response()->make(file_get_contents($path), 200, array_merge($headers, [
-                'Content-Type' => $this->file->mimeType($path),
-                'Content-Length' => filesize($path),
-            ]));
-        }
-        abort(404);
+        $searchTerm = $request->get('term');
+        $imgData = $this->imageRepo->searchPaginatedByType($type, $page, 24, $searchTerm);
+        return response()->json($imgData);
+    }
+
+    /**
+     * Get all images for a user.
+     * @param int $page
+     * @return \Illuminate\Http\JsonResponse
+     */
+    public function getAllForUserType($page = 0)
+    {
+        $imgData = $this->imageRepo->getPaginatedByType('user', $page, 24, $this->currentUser->id);
+        return response()->json($imgData);
+    }
+
+    /**
+     * Get gallery images with a specific filter such as book or page
+     * @param $filter
+     * @param int $page
+     * @param Request $request
+     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response
+     */
+    public function getGalleryFiltered($filter, $page = 0, Request $request)
+    {
+        $this->validate($request, [
+            'page_id' => 'required|integer'
+        ]);
+
+        $validFilters = collect(['page', 'book']);
+        if (!$validFilters->contains($filter)) return response('Invalid filter', 500);
+
+        $pageId = $request->get('page_id');
+        $imgData = $this->imageRepo->getGalleryFiltered($page, 24, strtolower($filter), $pageId);
+
+        return response()->json($imgData);

     }
 
     /**
      * Handles image uploads for use on pages.
     }
 
     /**
      * Handles image uploads for use on pages.

+     * @param string $type

      * @param Request $request
      * @return \Illuminate\Http\JsonResponse
      */
      * @param Request $request
      * @return \Illuminate\Http\JsonResponse
      */

-    public function upload(Request $request)
+    public function uploadByType($type, Request $request)

     {
     {

+        $this->checkPermission('image-create-all');
+        $this->validate($request, [
+            'file' => 'is_image'
+        ]);
+

         $imageUpload = $request->file('file');
         $imageUpload = $request->file('file');

-        $name = $imageUpload->getClientOriginalName();
-        $imagePath = '/images/' . Date('Y-m-M') . '/';
-        $storagePath = storage_path(). $imagePath;
-        $fullPath = $storagePath . $name;
-        while(file_exists($fullPath)) {
-            $name = substr(sha1(rand()), 0, 3) . $name;
-            $fullPath = $storagePath . $name;
+
+        try {
+            $uploadedTo = $request->has('uploaded_to') ? $request->get('uploaded_to') : 0;
+            $image = $this->imageRepo->saveNew($imageUpload, $type, $uploadedTo);
+        } catch (ImageUploadException $e) {
+            return response($e->getMessage(), 500);

         }
         }

-        $imageUpload->move($storagePath, $name);
-        // Create and save image object
-        $this->image->name = $name;
-        $this->image->url = $imagePath . $name;
-        $this->image->save();
-        return response()->json(['link' => $this->image->url]);
+
+        return response()->json($image);
+    }
+
+    /**
+     * Generate a sized thumbnail for an image.
+     * @param $id
+     * @param $width
+     * @param $height
+     * @param $crop
+     * @return \Illuminate\Http\JsonResponse
+     */
+    public function getThumbnail($id, $width, $height, $crop)
+    {
+        $this->checkPermission('image-create-all');
+        $image = $this->imageRepo->getById($id);
+        $thumbnailUrl = $this->imageRepo->getThumbnail($image, $width, $height, $crop == 'false');
+        return response()->json(['url' => $thumbnailUrl]);
+    }
+
+    /**
+     * Update image details
+     * @param integer $imageId
+     * @param Request $request
+     * @return \Illuminate\Http\JsonResponse
+     */
+    public function update($imageId, Request $request)
+    {
+        $this->validate($request, [
+            'name' => 'required|min:2|string'
+        ]);
+        $image = $this->imageRepo->getById($imageId);
+        $this->checkOwnablePermission('image-update', $image);
+        $image = $this->imageRepo->updateImageDetails($image, $request->all());
+        return response()->json($image);
+    }
+
+    /**
+     * Deletes an image and all thumbnail/image files
+     * @param EntityRepo $entityRepo
+     * @param Request $request
+     * @param int $id
+     * @return \Illuminate\Http\JsonResponse
+     */
+    public function destroy(EntityRepo $entityRepo, Request $request, $id)
+    {
+        $image = $this->imageRepo->getById($id);
+        $this->checkOwnablePermission('image-delete', $image);
+
+        // Check if this image is used on any pages
+        $isForced = ($request->has('force') && ($request->get('force') === 'true') || $request->get('force') === true);
+        if (!$isForced) {
+            $pageSearch = $entityRepo->searchForImage($image->url);
+            if ($pageSearch !== false) {
+                return response()->json($pageSearch, 400);
+            }
+        }
+
+        $this->imageRepo->destroyImage($image);
+        return response()->json(trans('components.images_deleted'));

     }
 
 
     }