Fixes for CodeStyle vol.2

[bookstack] / tests / Entity / PageDraftTest.php

diff --git a/tests/Entity/PageDraftTest.php b/tests/Entity/PageDraftTest.php
index b8ac9d3aeef6d37f86022986a8371b725aa1028a..68059af6e7126d1c2b75487d425b6c684a8aca3e 100644 (file)
--- a/tests/Entity/PageDraftTest.php
+++ b/tests/Entity/PageDraftTest.php
@@ -1,97 +1,117 @@
-<?php namespace Tests;
+<?php

 
 

+namespace Tests\Entity;
+
+use BookStack\Entities\Models\Page;
+use BookStack\Entities\Repos\PageRepo;
+use Tests\BrowserKitTest;

 
 class PageDraftTest extends BrowserKitTest
 {
     protected $page;
 
 class PageDraftTest extends BrowserKitTest
 {
     protected $page;

-    protected $entityRepo;

 
 

-    public function setUp()
+    /**
+     * @var PageRepo
+     */
+    protected $pageRepo;
+
+    public function setUp(): void

     {
         parent::setUp();
     {
         parent::setUp();

-        $this->page = \BookStack\Page::first();
-        $this->entityRepo = app('\BookStack\Repos\EntityRepo');
+        $this->page = \BookStack\Entities\Models\Page::first();
+        $this->pageRepo = app(PageRepo::class);

     }
 
     public function test_draft_content_shows_if_available()
     {
         $addedContent = '<p>test message content</p>';
     }
 
     public function test_draft_content_shows_if_available()
     {
         $addedContent = '<p>test message content</p>';

-        $this->asAdmin()->visit($this->page->getUrl() . '/edit')
+        $this->asAdmin()->visit($this->page->getUrl('/edit'))

             ->dontSeeInField('html', $addedContent);
 
         $newContent = $this->page->html . $addedContent;
             ->dontSeeInField('html', $addedContent);
 
         $newContent = $this->page->html . $addedContent;

-        $this->entityRepo->updatePageDraft($this->page, ['html' => $newContent]);
-        $this->asAdmin()->visit($this->page->getUrl() . '/edit')
+        $this->pageRepo->updatePageDraft($this->page, ['html' => $newContent]);
+        $this->asAdmin()->visit($this->page->getUrl('/edit'))

             ->seeInField('html', $newContent);
     }
 
     public function test_draft_not_visible_by_others()
     {
         $addedContent = '<p>test message content</p>';
             ->seeInField('html', $newContent);
     }
 
     public function test_draft_not_visible_by_others()
     {
         $addedContent = '<p>test message content</p>';

-        $this->asAdmin()->visit($this->page->getUrl() . '/edit')
+        $this->asAdmin()->visit($this->page->getUrl('/edit'))

             ->dontSeeInField('html', $addedContent);
 
         $newContent = $this->page->html . $addedContent;
         $newUser = $this->getEditor();
             ->dontSeeInField('html', $addedContent);
 
         $newContent = $this->page->html . $addedContent;
         $newUser = $this->getEditor();

-        $this->entityRepo->updatePageDraft($this->page, ['html' => $newContent]);
-        $this->actingAs($newUser)->visit($this->page->getUrl() . '/edit')
+        $this->pageRepo->updatePageDraft($this->page, ['html' => $newContent]);
+
+        $this->actingAs($newUser)->visit($this->page->getUrl('/edit'))

             ->dontSeeInField('html', $newContent);
     }
 
     public function test_alert_message_shows_if_editing_draft()
     {
         $this->asAdmin();
             ->dontSeeInField('html', $newContent);
     }
 
     public function test_alert_message_shows_if_editing_draft()
     {
         $this->asAdmin();

-        $this->entityRepo->updatePageDraft($this->page, ['html' => 'test content']);
-        $this->asAdmin()->visit($this->page->getUrl() . '/edit')
+        $this->pageRepo->updatePageDraft($this->page, ['html' => 'test content']);
+        $this->asAdmin()->visit($this->page->getUrl('/edit'))

             ->see('You are currently editing a draft');
     }
 
     public function test_alert_message_shows_if_someone_else_editing()
     {
             ->see('You are currently editing a draft');
     }
 
     public function test_alert_message_shows_if_someone_else_editing()
     {

-        $nonEditedPage = \BookStack\Page::take(10)->get()->last();
+        $nonEditedPage = \BookStack\Entities\Models\Page::take(10)->get()->last();

         $addedContent = '<p>test message content</p>';
         $addedContent = '<p>test message content</p>';

-        $this->asAdmin()->visit($this->page->getUrl() . '/edit')
+        $this->asAdmin()->visit($this->page->getUrl('/edit'))

             ->dontSeeInField('html', $addedContent);
 
         $newContent = $this->page->html . $addedContent;
         $newUser = $this->getEditor();
             ->dontSeeInField('html', $addedContent);
 
         $newContent = $this->page->html . $addedContent;
         $newUser = $this->getEditor();

-        $this->entityRepo->updatePageDraft($this->page, ['html' => $newContent]);
+        $this->pageRepo->updatePageDraft($this->page, ['html' => $newContent]);

 
         $this->actingAs($newUser)
 
         $this->actingAs($newUser)

-            ->visit($this->page->getUrl() . '/edit')
+            ->visit($this->page->getUrl('/edit'))

             ->see('Admin has started editing this page');
             ->see('Admin has started editing this page');

-            $this->flushSession();
+        $this->flushSession();

         $this->visit($nonEditedPage->getUrl() . '/edit')
             ->dontSeeInElement('.notification', 'Admin has started editing this page');
     }
 
     public function test_draft_pages_show_on_homepage()
     {
         $this->visit($nonEditedPage->getUrl() . '/edit')
             ->dontSeeInElement('.notification', 'Admin has started editing this page');
     }
 
     public function test_draft_pages_show_on_homepage()
     {

-        $book = \BookStack\Book::first();
+        $book = \BookStack\Entities\Models\Book::first();

         $this->asAdmin()->visit('/')
             ->dontSeeInElement('#recent-drafts', 'New Page')
         $this->asAdmin()->visit('/')
             ->dontSeeInElement('#recent-drafts', 'New Page')

-            ->visit($book->getUrl() . '/page/create')
+            ->visit($book->getUrl() . '/create-page')

             ->visit('/')
             ->seeInElement('#recent-drafts', 'New Page');
     }
 
     public function test_draft_pages_not_visible_by_others()
     {
             ->visit('/')
             ->seeInElement('#recent-drafts', 'New Page');
     }
 
     public function test_draft_pages_not_visible_by_others()
     {

-        $book = \BookStack\Book::first();
+        $book = \BookStack\Entities\Models\Book::first();

         $chapter = $book->chapters->first();
         $newUser = $this->getEditor();
 
         $this->actingAs($newUser)->visit('/')
         $chapter = $book->chapters->first();
         $newUser = $this->getEditor();
 
         $this->actingAs($newUser)->visit('/')

-            ->visit($book->getUrl() . '/page/create')
-            ->visit($chapter->getUrl() . '/create-page')
+            ->visit($book->getUrl('/create-page'))
+            ->visit($chapter->getUrl('/create-page'))

             ->visit($book->getUrl())
             ->visit($book->getUrl())

-            ->seeInElement('.page-list', 'New Page');
-        
+            ->seeInElement('.book-contents', 'New Page');
+

         $this->asAdmin()
             ->visit($book->getUrl())
         $this->asAdmin()
             ->visit($book->getUrl())

-            ->dontSeeInElement('.page-list', 'New Page')
+            ->dontSeeInElement('.book-contents', 'New Page')

             ->visit($chapter->getUrl())
             ->visit($chapter->getUrl())

-            ->dontSeeInElement('.page-list', 'New Page');
+            ->dontSeeInElement('.book-contents', 'New Page');

     }
 
     }
 

+    public function test_page_html_in_ajax_fetch_response()
+    {
+        $this->asAdmin();
+        $page = Page::query()->first();
+
+        $this->getJson('/ajax/page/' . $page->id);
+        $this->seeJson([
+            'html' => $page->html,
+        ]);
+    }

 }
 }