Checked over recycle bin parent/child flows

[bookstack] / app / Http / Controllers / SearchController.php

diff --git a/app/Http/Controllers/SearchController.php b/app/Http/Controllers/SearchController.php
index 8ce5aaa7461bdc839e49e7f14b8ba6ef3055f318..8105843b576acb9072651c878190a5489968f7b4 100644 (file)
--- a/app/Http/Controllers/SearchController.php
+++ b/app/Http/Controllers/SearchController.php
@@ -1,90 +1,82 @@
 <?php namespace BookStack\Http\Controllers;
 
 use BookStack\Actions\ViewService;
 <?php namespace BookStack\Http\Controllers;
 
 use BookStack\Actions\ViewService;

-use BookStack\Entities\Repos\EntityRepo;
+use BookStack\Entities\Book;
+use BookStack\Entities\Bookshelf;
+use BookStack\Entities\Entity;
+use BookStack\Entities\Managers\EntityContext;

 use BookStack\Entities\SearchService;
 use BookStack\Entities\SearchService;

-use BookStack\Exceptions\NotFoundException;
+use BookStack\Entities\SearchOptions;

 use Illuminate\Http\Request;
 
 class SearchController extends Controller
 {
 use Illuminate\Http\Request;
 
 class SearchController extends Controller
 {

-    protected $entityRepo;

     protected $viewService;
     protected $searchService;
     protected $viewService;
     protected $searchService;

+    protected $entityContextManager;

 
     /**
      * SearchController constructor.
 
     /**
      * SearchController constructor.

-     * @param \BookStack\Entities\Repos\EntityRepo $entityRepo
-     * @param ViewService $viewService
-     * @param SearchService $searchService

      */
      */

-    public function __construct(EntityRepo $entityRepo, ViewService $viewService, SearchService $searchService)
-    {
-        $this->entityRepo = $entityRepo;
+    public function __construct(
+        ViewService $viewService,
+        SearchService $searchService,
+        EntityContext $entityContextManager
+    ) {

         $this->viewService = $viewService;
         $this->searchService = $searchService;
         $this->viewService = $viewService;
         $this->searchService = $searchService;

+        $this->entityContextManager = $entityContextManager;

         parent::__construct();
     }
 
     /**
      * Searches all entities.
         parent::__construct();
     }
 
     /**
      * Searches all entities.

-     * @param Request $request
-     * @return \Illuminate\View\View
-     * @internal param string $searchTerm

      */
     public function search(Request $request)
     {
      */
     public function search(Request $request)
     {

-        $searchTerm = $request->get('term');
-        $this->setPageTitle(trans('entities.search_for_term', ['term' => $searchTerm]));
+        $searchOpts = SearchOptions::fromRequest($request);
+        $fullSearchString = $searchOpts->toString();
+        $this->setPageTitle(trans('entities.search_for_term', ['term' => $fullSearchString]));

 
         $page = intval($request->get('page', '0')) ?: 1;
 
         $page = intval($request->get('page', '0')) ?: 1;

-        $nextPageLink = baseUrl('/search?term=' . urlencode($searchTerm) . '&page=' . ($page+1));
+        $nextPageLink = url('/search?term=' . urlencode($fullSearchString) . '&page=' . ($page+1));

 
 

-        $results = $this->searchService->searchEntities($searchTerm, 'all', $page, 20);
+        $results = $this->searchService->searchEntities($searchOpts, 'all', $page, 20);

 
 

-        return view('search/all', [
+        return view('search.all', [

             'entities'   => $results['results'],
             'totalResults' => $results['total'],
             'entities'   => $results['results'],
             'totalResults' => $results['total'],

-            'searchTerm' => $searchTerm,
+            'searchTerm' => $fullSearchString,

             'hasNextPage' => $results['has_more'],
             'hasNextPage' => $results['has_more'],

-            'nextPageLink' => $nextPageLink
+            'nextPageLink' => $nextPageLink,
+            'options' => $searchOpts,

         ]);
     }
 
 
     /**
      * Searches all entities within a book.
         ]);
     }
 
 
     /**
      * Searches all entities within a book.

-     * @param Request $request
-     * @param integer $bookId
-     * @return \Illuminate\View\View
-     * @internal param string $searchTerm

      */
      */

-    public function searchBook(Request $request, $bookId)
+    public function searchBook(Request $request, int $bookId)

     {
         $term = $request->get('term', '');
         $results = $this->searchService->searchBook($bookId, $term);
     {
         $term = $request->get('term', '');
         $results = $this->searchService->searchBook($bookId, $term);

-        return view('partials/entity-list', ['entities' => $results]);
+        return view('partials.entity-list', ['entities' => $results]);

     }
 
     /**
      * Searches all entities within a chapter.
     }
 
     /**
      * Searches all entities within a chapter.

-     * @param Request $request
-     * @param integer $chapterId
-     * @return \Illuminate\View\View
-     * @internal param string $searchTerm

      */
      */

-    public function searchChapter(Request $request, $chapterId)
+    public function searchChapter(Request $request, int $chapterId)

     {
         $term = $request->get('term', '');
         $results = $this->searchService->searchChapter($chapterId, $term);
     {
         $term = $request->get('term', '');
         $results = $this->searchService->searchChapter($chapterId, $term);

-        return view('partials/entity-list', ['entities' => $results]);
+        return view('partials.entity-list', ['entities' => $results]);

     }
 
     /**
      * Search for a list of entities and return a partial HTML response of matching entities.
      * Returns the most popular entities if no search is provided.
     }
 
     /**
      * Search for a list of entities and return a partial HTML response of matching entities.
      * Returns the most popular entities if no search is provided.

-     * @param Request $request
-     * @return mixed

      */
     public function searchEntitiesAjax(Request $request)
     {
      */
     public function searchEntitiesAjax(Request $request)
     {


@@ -95,7 +87,7 @@ class SearchController extends Controller
         // Search for entities otherwise show most popular
         if ($searchTerm !== false) {
             $searchTerm .= ' {type:'. implode('|', $entityTypes) .'}';
         // Search for entities otherwise show most popular
         if ($searchTerm !== false) {
             $searchTerm .= ' {type:'. implode('|', $entityTypes) .'}';

-            $entities = $this->searchService->searchEntities($searchTerm, 'all', 1, 20, $permission)['results'];
+            $entities = $this->searchService->searchEntities(SearchOptions::fromString($searchTerm), 'all', 1, 20, $permission)['results'];

         } else {
             $entities = $this->viewService->getPopular(20, 0, $entityTypes, $permission);
         }
         } else {
             $entities = $this->viewService->getPopular(20, 0, $entityTypes, $permission);
         }


@@ -105,15 +97,13 @@ class SearchController extends Controller
 
     /**
      * Search siblings items in the system.
 
     /**
      * Search siblings items in the system.

-     * @param Request $request
-     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View|mixed

      */
     public function searchSiblings(Request $request)
     {
         $type = $request->get('entity_type', null);
         $id = $request->get('entity_id', null);
 
      */
     public function searchSiblings(Request $request)
     {
         $type = $request->get('entity_type', null);
         $id = $request->get('entity_id', null);
 

-        $entity = $this->entityRepo->getById($type, $id);
+        $entity = Entity::getEntityInstance($type)->newQuery()->visible()->find($id);

         if (!$entity) {
             return $this->jsonError(trans('errors.entity_not_found'), 404);
         }
         if (!$entity) {
             return $this->jsonError(trans('errors.entity_not_found'), 404);
         }


@@ -122,24 +112,29 @@ class SearchController extends Controller
 
         // Page in chapter
         if ($entity->isA('page') && $entity->chapter) {
 
         // Page in chapter
         if ($entity->isA('page') && $entity->chapter) {

-            $entities = $this->entityRepo->getChapterChildren($entity->chapter);
+            $entities = $entity->chapter->getVisiblePages();

         }
 
         // Page in book or chapter
         if (($entity->isA('page') && !$entity->chapter) || $entity->isA('chapter')) {
         }
 
         // Page in book or chapter
         if (($entity->isA('page') && !$entity->chapter) || $entity->isA('chapter')) {

-            $entities = $this->entityRepo->getBookDirectChildren($entity->book);
+            $entities = $entity->book->getDirectChildren();

         }
 
         }
 

-        // Book in shelf
-        // TODO - When shelve tracking added, Update below if criteria
-

         // Book
         // Book

+        // Gets just the books in a shelf if shelf is in context

         if ($entity->isA('book')) {
         if ($entity->isA('book')) {

-            $entities = $this->entityRepo->getAll('book');
+            $contextShelf = $this->entityContextManager->getContextualShelfForBook($entity);
+            if ($contextShelf) {
+                $entities = $contextShelf->visibleBooks()->get();
+            } else {
+                $entities = Book::visible()->get();
+            }

         }
 
         // Shelve
         }
 
         // Shelve

-        // TODO - When shelve tracking added
+        if ($entity->isA('bookshelf')) {
+            $entities = Bookshelf::visible()->get();
+        }

 
         return view('partials.entity-list-basic', ['entities' => $entities, 'style' => 'compact']);
     }
 
         return view('partials.entity-list-basic', ['entities' => $entities, 'style' => 'compact']);
     }