Fixes for CodeStyle vol.2

[bookstack] / tests / TestCase.php

diff --git a/tests/TestCase.php b/tests/TestCase.php
index f3f36ca1cc75daa3211c82d0ee5eec2628891b33..080515173d67cdd6cdf3605dc9e66c7ad1de42a4 100644 (file)
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -1,9 +1,8 @@
-<?php namespace Tests;
+<?php

 
 

-use BookStack\Book;
-use BookStack\Chapter;
-use BookStack\Repos\EntityRepo;
-use BookStack\Role;
+namespace Tests;
+
+use BookStack\Entities\Models\Entity;

 use Illuminate\Foundation\Testing\DatabaseTransactions;
 use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
 
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
 


@@ -11,69 +10,67 @@ abstract class TestCase extends BaseTestCase
 {
     use CreatesApplication;
     use DatabaseTransactions;
 {
     use CreatesApplication;
     use DatabaseTransactions;

+    use SharedTestHelpers;

 
 

-    protected $admin;
-    protected $editor;
+    /**
+     * The base URL to use while testing the application.
+     *
+     * @var string
+     */
+    protected $baseUrl = 'http://localhost';

 
     /**
 
     /**

-     * Set the current user context to be an admin.
+     * Assert the session contains a specific entry.
+     *
+     * @param string $key
+     *

      * @return $this
      */
      * @return $this
      */

-    public function asAdmin()
+    protected function assertSessionHas(string $key)

     {
     {

-        return $this->actingAs($this->getAdmin());
-    }
+        $this->assertTrue(session()->has($key), "Session does not contain a [{$key}] entry");

 
 

-    /**
-     * Get the current admin user.
-     * @return mixed
-     */
-    public function getAdmin() {
-        if($this->admin === null) {
-            $adminRole = Role::getSystemRole('admin');
-            $this->admin = $adminRole->users->first();
-        }
-        return $this->admin;
+        return $this;

     }
 
     /**
     }
 
     /**

-     * Set the current user context to be an editor.
-     * @return $this
+     * Override of the get method so we can get visibility of custom TestResponse methods.
+     *
+     * @param string $uri
+     * @param array  $headers
+     *
+     * @return TestResponse

      */
      */

-    public function asEditor()
+    public function get($uri, array $headers = [])

     {
     {

-        return $this->actingAs($this->getEditor());
+        return parent::get($uri, $headers);

     }
 
     }
 

-

     /**
     /**

-     * Get a editor user.
-     * @return mixed
+     * Create the test response instance from the given response.
+     *
+     * @param \Illuminate\Http\Response $response
+     *
+     * @return TestResponse

      */
      */

-    public function getEditor() {
-        if($this->editor === null) {
-            $editorRole = Role::getRole('editor');
-            $this->editor = $editorRole->users->first();
-        }
-        return $this->editor;
+    protected function createTestResponse($response)
+    {
+        return TestResponse::fromBaseResponse($response);

     }
 
     /**
     }
 
     /**

-     * Create and return a new book.
-     * @param array $input
-     * @return Book
+     * Assert that an activity entry exists of the given key.
+     * Checks the activity belongs to the given entity if provided.

      */
      */

-    public function newBook($input = ['name' => 'test book', 'description' => 'My new test book']) {
-        return $this->app[EntityRepo::class]->createFromInput('book', $input, false);
-    }
+    protected function assertActivityExists(string $type, Entity $entity = null)
+    {
+        $detailsToCheck = ['type' => $type];

 
 

-    /**
-     * Create and return a new test chapter
-     * @param array $input
-     * @param Book $book
-     * @return Chapter
-     */
-    public function newChapter($input = ['name' => 'test chapter', 'description' => 'My new test chapter'], Book $book) {
-        return $this->app[EntityRepo::class]->createFromInput('chapter', $input, $book);
+        if ($entity) {
+            $detailsToCheck['entity_type'] = $entity->getMorphClass();
+            $detailsToCheck['entity_id'] = $entity->id;
+        }
+
+        $this->assertDatabaseHas('activities', $detailsToCheck);

     }
     }

-}
\ No newline at end of file
+}