Fixes for CodeStyle vol.2

[bookstack] / tests / BrowserKitTest.php

diff --git a/tests/BrowserKitTest.php b/tests/BrowserKitTest.php
index 7917a0c409e881a7b8790c9a7c19584c5f1b0327..23eb1088773cf8499286eba5c3b858f10edad6a9 100644 (file)
--- a/tests/BrowserKitTest.php
+++ b/tests/BrowserKitTest.php
@@ -1,10 +1,12 @@
-<?php namespace Tests;
+<?php

 
 

+namespace Tests;
+
+use BookStack\Auth\Permissions\PermissionService;

 use BookStack\Auth\User;
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Chapter;
 use BookStack\Entities\Models\Entity;
 use BookStack\Auth\User;
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Chapter;
 use BookStack\Entities\Models\Entity;

-use BookStack\Auth\Permissions\PermissionService;

 use BookStack\Entities\Models\Page;
 use BookStack\Settings\SettingService;
 use DB;
 use BookStack\Entities\Models\Page;
 use BookStack\Settings\SettingService;
 use DB;


@@ -16,17 +18,17 @@ use Symfony\Component\DomCrawler\Crawler;
 
 abstract class BrowserKitTest extends TestCase
 {
 
 abstract class BrowserKitTest extends TestCase
 {

-

     use DatabaseTransactions;
     use SharedTestHelpers;
 
     /**
      * The base URL to use while testing the application.
     use DatabaseTransactions;
     use SharedTestHelpers;
 
     /**
      * The base URL to use while testing the application.

+     *

      * @var string
      */
     protected $baseUrl = 'http://localhost';
 
      * @var string
      */
     protected $baseUrl = 'http://localhost';
 

-    public function tearDown() : void
+    public function tearDown(): void

     {
         DB::disconnect();
         parent::tearDown();
     {
         DB::disconnect();
         parent::tearDown();


@@ -39,16 +41,16 @@ abstract class BrowserKitTest extends TestCase
      */
     public function createApplication()
     {
      */
     public function createApplication()
     {

-        $app = require __DIR__.'/../bootstrap/app.php';
+        $app = require __DIR__ . '/../bootstrap/app.php';

 
         $app->make(Kernel::class)->bootstrap();
 
         return $app;
     }
 
 
         $app->make(Kernel::class)->bootstrap();
 
         return $app;
     }
 

-

     /**
      * Quickly sets an array of settings.
     /**
      * Quickly sets an array of settings.

+     *

      * @param $settingsArray
      */
     protected function setSettings($settingsArray)
      * @param $settingsArray
      */
     protected function setSettings($settingsArray)


@@ -80,6 +82,7 @@ abstract class BrowserKitTest extends TestCase
 
     /**
      * Helper for updating entity permissions.
 
     /**
      * Helper for updating entity permissions.

+     *

      * @param Entity $entity
      */
     protected function updateEntityPermissions(Entity $entity)
      * @param Entity $entity
      */
     protected function updateEntityPermissions(Entity $entity)


@@ -88,25 +91,28 @@ abstract class BrowserKitTest extends TestCase
         $restrictionService->buildJointPermissionsForEntity($entity);
     }
 
         $restrictionService->buildJointPermissionsForEntity($entity);
     }
 

-

     /**
     /**

-     * Quick way to create a new user without any permissions
+     * Quick way to create a new user without any permissions.
+     *

      * @param array $attributes
      * @param array $attributes

+     *

      * @return mixed
      */
     protected function getNewBlankUser($attributes = [])
     {
         $user = factory(User::class)->create($attributes);
      * @return mixed
      */
     protected function getNewBlankUser($attributes = [])
     {
         $user = factory(User::class)->create($attributes);

+

         return $user;
     }
 
     /**
      * Assert that a given string is seen inside an element.
      *
         return $user;
     }
 
     /**
      * Assert that a given string is seen inside an element.
      *

-     * @param  bool|string|null $element
-     * @param  integer          $position
-     * @param  string           $text
-     * @param  bool             $negate
+     * @param bool|string|null $element
+     * @param int              $position
+     * @param string           $text
+     * @param bool             $negate
+     *

      * @return $this
      */
     protected function seeInNthElement($element, $position, $text, $negate = false)
      * @return $this
      */
     protected function seeInNthElement($element, $position, $text, $negate = false)


@@ -130,13 +136,16 @@ abstract class BrowserKitTest extends TestCase
     /**
      * Assert that the current page matches a given URI.
      *
     /**
      * Assert that the current page matches a given URI.
      *

-     * @param  string  $uri
+     * @param string $uri
+     *

      * @return $this
      */
     protected function seePageUrlIs($uri)
     {
         $this->assertEquals(
      * @return $this
      */
     protected function seePageUrlIs($uri)
     {
         $this->assertEquals(

-            $uri, $this->currentUri, "Did not land on expected page [{$uri}].\n"
+            $uri,
+            $this->currentUri,
+            "Did not land on expected page [{$uri}].\n"

         );
 
         return $this;
         );
 
         return $this;


@@ -144,10 +153,12 @@ abstract class BrowserKitTest extends TestCase
 
     /**
      * Do a forced visit that does not error out on exception.
 
     /**
      * Do a forced visit that does not error out on exception.

+     *

      * @param string $uri
      * @param string $uri

-     * @param array $parameters
-     * @param array $cookies
-     * @param array $files
+     * @param array  $parameters
+     * @param array  $cookies
+     * @param array  $files
+     *

      * @return $this
      */
     protected function forceVisit($uri, $parameters = [], $cookies = [], $files = [])
      * @return $this
      */
     protected function forceVisit($uri, $parameters = [], $cookies = [], $files = [])


@@ -158,13 +169,16 @@ abstract class BrowserKitTest extends TestCase
         $this->clearInputs()->followRedirects();
         $this->currentUri = $this->app->make('request')->fullUrl();
         $this->crawler = new Crawler($this->response->getContent(), $uri);
         $this->clearInputs()->followRedirects();
         $this->currentUri = $this->app->make('request')->fullUrl();
         $this->crawler = new Crawler($this->response->getContent(), $uri);

+

         return $this;
     }
 
     /**
      * Click the text within the selected element.
         return $this;
     }
 
     /**
      * Click the text within the selected element.

+     *

      * @param $parentElement
      * @param $linkText
      * @param $parentElement
      * @param $linkText

+     *

      * @return $this
      */
     protected function clickInElement($parentElement, $linkText)
      * @return $this
      */
     protected function clickInElement($parentElement, $linkText)


@@ -172,28 +186,33 @@ abstract class BrowserKitTest extends TestCase
         $elem = $this->crawler->filter($parentElement);
         $link = $elem->selectLink($linkText);
         $this->visit($link->link()->getUri());
         $elem = $this->crawler->filter($parentElement);
         $link = $elem->selectLink($linkText);
         $this->visit($link->link()->getUri());

+

         return $this;
     }
 
     /**
      * Check if the page contains the given element.
         return $this;
     }
 
     /**
      * Check if the page contains the given element.

-     * @param  string  $selector
+     *
+     * @param string $selector

      */
     protected function pageHasElement($selector)
     {
         $elements = $this->crawler->filter($selector);
      */
     protected function pageHasElement($selector)
     {
         $elements = $this->crawler->filter($selector);

-        $this->assertTrue(count($elements) > 0, "The page does not contain an element matching " . $selector);
+        $this->assertTrue(count($elements) > 0, 'The page does not contain an element matching ' . $selector);
+

         return $this;
     }
 
     /**
      * Check if the page contains the given element.
         return $this;
     }
 
     /**
      * Check if the page contains the given element.

-     * @param  string  $selector
+     *
+     * @param string $selector

      */
     protected function pageNotHasElement($selector)
     {
         $elements = $this->crawler->filter($selector);
      */
     protected function pageNotHasElement($selector)
     {
         $elements = $this->crawler->filter($selector);

-        $this->assertFalse(count($elements) > 0, "The page contains " . count($elements) . " elements matching " . $selector);
+        $this->assertFalse(count($elements) > 0, 'The page contains ' . count($elements) . ' elements matching ' . $selector);
+

         return $this;
     }
 }
         return $this;
     }
 }