Themes: Documented public file serving

[bookstack] / tests / Entity / PageTest.php

diff --git a/tests/Entity/PageTest.php b/tests/Entity/PageTest.php
index e1dffb61faf05ae078502ed0a7f5bd2de9ea30a9..deeead099110aa56271004cdc437e305678160ee 100644 (file)
--- a/tests/Entity/PageTest.php
+++ b/tests/Entity/PageTest.php
@@ -1,17 +1,45 @@
-<?php namespace Tests\Entity;
+<?php
+
+namespace Tests\Entity;

 
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Page;
 
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Page;

+use Carbon\Carbon;

 use Tests\TestCase;
 
 class PageTest extends TestCase
 {
 use Tests\TestCase;
 
 class PageTest extends TestCase
 {

+    public function test_create()
+    {
+        $chapter = $this->entities->chapter();
+        $page = Page::factory()->make([
+            'name' => 'My First Page',
+        ]);
+
+        $resp = $this->asEditor()->get($chapter->getUrl());
+        $this->withHtml($resp)->assertElementContains('a[href="' . $chapter->getUrl('/create-page') . '"]', 'New Page');
+
+        $resp = $this->get($chapter->getUrl('/create-page'));
+        /** @var Page $draftPage */
+        $draftPage = Page::query()
+            ->where('draft', '=', true)
+            ->orderBy('created_at', 'desc')
+            ->first();
+        $resp->assertRedirect($draftPage->getUrl());
+
+        $resp = $this->get($draftPage->getUrl());
+        $this->withHtml($resp)->assertElementContains('form[action="' . $draftPage->getUrl() . '"][method="POST"]', 'Save Page');
+
+        $resp = $this->post($draftPage->getUrl(), $draftPage->only('name', 'html'));
+        $draftPage->refresh();
+        $resp->assertRedirect($draftPage->getUrl());
+    }

 
     public function test_page_view_when_creator_is_deleted_but_owner_exists()
     {
 
     public function test_page_view_when_creator_is_deleted_but_owner_exists()
     {

-        $page = Page::query()->first();
-        $user = $this->getViewer();
-        $owner = $this->getEditor();
+        $page = $this->entities->page();
+        $user = $this->users->viewer();
+        $owner = $this->users->editor();

         $page->created_by = $user->id;
         $page->owned_by = $owner->id;
         $page->save();
         $page->created_by = $user->id;
         $page->owned_by = $owner->id;
         $page->save();


@@ -22,10 +50,17 @@ class PageTest extends TestCase
         $resp->assertSeeText('Owned by ' . $owner->name);
     }
 
         $resp->assertSeeText('Owned by ' . $owner->name);
     }
 

+    public function test_page_show_includes_pointer_section_select_mode_button()
+    {
+        $page = $this->entities->page();
+        $resp = $this->asEditor()->get($page->getUrl());
+        $this->withHtml($resp)->assertElementContains('.content-wrap button.screen-reader-only', 'Enter section select mode');
+    }
+

     public function test_page_creation_with_markdown_content()
     {
         $this->setSettings(['app-editor' => 'markdown']);
     public function test_page_creation_with_markdown_content()
     {
         $this->setSettings(['app-editor' => 'markdown']);

-        $book = Book::query()->first();
+        $book = $this->entities->book();

 
         $this->asEditor()->get($book->getUrl('/create-page'));
         $draft = Page::query()->where('book_id', '=', $book->id)
 
         $this->asEditor()->get($book->getUrl('/create-page'));
         $draft = Page::query()->where('book_id', '=', $book->id)


@@ -33,27 +68,53 @@ class PageTest extends TestCase
 
         $details = [
             'markdown' => '# a title',
 
         $details = [
             'markdown' => '# a title',

-            'html' => '<h1>a title</h1>',
-            'name' => 'my page',
+            'html'     => '<h1>a title</h1>',
+            'name'     => 'my page',

         ];
         $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
         $resp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [
             'markdown' => $details['markdown'],
         ];
         $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
         $resp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [
             'markdown' => $details['markdown'],

-            'name' => $details['name'],
-            'id' => $draft->id,
-            'draft' => false
+            'name'     => $details['name'],
+            'id'       => $draft->id,
+            'draft'    => false,
+        ]);
+
+        $draft->refresh();
+        $resp = $this->get($draft->getUrl('/edit'));
+        $resp->assertSee('# a title');
+    }
+
+    public function test_page_creation_allows_summary_to_be_set()
+    {
+        $book = $this->entities->book();
+
+        $this->asEditor()->get($book->getUrl('/create-page'));
+        $draft = Page::query()->where('book_id', '=', $book->id)
+            ->where('draft', '=', true)->first();
+
+        $details = [
+            'html'    => '<h1>a title</h1>',
+            'name'    => 'My page with summary',
+            'summary' => 'Here is my changelog message for a new page!',
+        ];
+        $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
+        $resp->assertRedirect();
+
+        $this->assertDatabaseHas('page_revisions', [
+            'page_id' => $draft->id,
+            'summary' => 'Here is my changelog message for a new page!',

         ]);
 
         $draft->refresh();
         ]);
 
         $draft->refresh();

-        $resp = $this->get($draft->getUrl("/edit"));
-        $resp->assertSee("# a title");
+        $resp = $this->get($draft->getUrl('/revisions'));
+        $resp->assertSee('Here is my changelog message for a new page!');

     }
 
     public function test_page_delete()
     {
     }
 
     public function test_page_delete()
     {

-        $page = Page::query()->first();
+        $page = $this->entities->page();

         $this->assertNull($page->deleted_at);
 
         $deleteViewReq = $this->asEditor()->get($page->getUrl('/delete'));
         $this->assertNull($page->deleted_at);
 
         $deleteViewReq = $this->asEditor()->get($page->getUrl('/delete'));


@@ -68,12 +129,38 @@ class PageTest extends TestCase
         $this->assertTrue($page->deletions()->count() === 1);
 
         $redirectReq = $this->get($deleteReq->baseResponse->headers->get('location'));
         $this->assertTrue($page->deletions()->count() === 1);
 
         $redirectReq = $this->get($deleteReq->baseResponse->headers->get('location'));

-        $redirectReq->assertNotificationContains('Page Successfully Deleted');
+        $this->assertNotificationContains($redirectReq, 'Page Successfully Deleted');
+    }
+
+    public function test_page_full_delete_removes_all_revisions()
+    {
+        $page = $this->entities->page();
+        $page->revisions()->create([
+            'html' => '<p>ducks</p>',
+            'name' => 'my page revision',
+            'type' => 'draft',
+        ]);
+        $page->revisions()->create([
+            'html' => '<p>ducks</p>',
+            'name' => 'my page revision',
+            'type' => 'revision',
+        ]);
+
+        $this->assertDatabaseHas('page_revisions', [
+            'page_id' => $page->id,
+        ]);
+
+        $this->asEditor()->delete($page->getUrl());
+        $this->asAdmin()->post('/settings/recycle-bin/empty');
+
+        $this->assertDatabaseMissing('page_revisions', [
+            'page_id' => $page->id,
+        ]);

     }
 
     public function test_page_copy()
     {
     }
 
     public function test_page_copy()
     {

-        $page = Page::first();
+        $page = $this->entities->page();

         $page->html = '<p>This is some test content</p>';
         $page->save();
 
         $page->html = '<p>This is some test content</p>';
         $page->save();
 


@@ -85,7 +172,7 @@ class PageTest extends TestCase
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,

-            'name' => 'My copied test page'
+            'name'             => 'My copied test page',

         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 
         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 


@@ -96,7 +183,7 @@ class PageTest extends TestCase
 
     public function test_page_copy_with_markdown_has_both_html_and_markdown()
     {
 
     public function test_page_copy_with_markdown_has_both_html_and_markdown()
     {

-        $page = Page::first();
+        $page = $this->entities->page();

         $page->html = '<h1>This is some test content</h1>';
         $page->markdown = '# This is some test content';
         $page->save();
         $page->html = '<h1>This is some test content</h1>';
         $page->markdown = '# This is some test content';
         $page->save();


@@ -104,7 +191,7 @@ class PageTest extends TestCase
 
         $this->asEditor()->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,
 
         $this->asEditor()->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,

-            'name' => 'My copied test page'
+            'name'             => 'My copied test page',

         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 
         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 


@@ -114,14 +201,14 @@ class PageTest extends TestCase
 
     public function test_page_copy_with_no_destination()
     {
 
     public function test_page_copy_with_no_destination()
     {

-        $page = Page::first();
+        $page = $this->entities->page();

         $currentBook = $page->book;
 
         $resp = $this->asEditor()->get($page->getUrl('/copy'));
         $resp->assertSee('Copy Page');
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
         $currentBook = $page->book;
 
         $resp = $this->asEditor()->get($page->getUrl('/copy'));
         $resp->assertSee('Copy Page');
 
         $movePageResp = $this->post($page->getUrl('/copy'), [

-            'name' => 'My copied test page'
+            'name' => 'My copied test page',

         ]);
 
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
         ]);
 
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();


@@ -133,55 +220,140 @@ class PageTest extends TestCase
 
     public function test_page_can_be_copied_without_edit_permission()
     {
 
     public function test_page_can_be_copied_without_edit_permission()
     {

-        $page = Page::first();
+        $page = $this->entities->page();

         $currentBook = $page->book;
         $newBook = Book::where('id', '!=', $currentBook->id)->first();
         $currentBook = $page->book;
         $newBook = Book::where('id', '!=', $currentBook->id)->first();

-        $viewer = $this->getViewer();
+        $viewer = $this->users->viewer();

 
         $resp = $this->actingAs($viewer)->get($page->getUrl());
         $resp->assertDontSee($page->getUrl('/copy'));
 
         $newBook->owned_by = $viewer->id;
         $newBook->save();
 
         $resp = $this->actingAs($viewer)->get($page->getUrl());
         $resp->assertDontSee($page->getUrl('/copy'));
 
         $newBook->owned_by = $viewer->id;
         $newBook->save();

-        $this->giveUserPermissions($viewer, ['page-create-own']);
-        $this->regenEntityPermissions($newBook);
+        $this->permissions->grantUserRolePermissions($viewer, ['page-create-own']);
+        $this->permissions->regenerateForEntity($newBook);

 
         $resp = $this->actingAs($viewer)->get($page->getUrl());
         $resp->assertSee($page->getUrl('/copy'));
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,
 
         $resp = $this->actingAs($viewer)->get($page->getUrl());
         $resp->assertSee($page->getUrl('/copy'));
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,

-            'name' => 'My copied test page'
+            'name'             => 'My copied test page',

         ]);
         $movePageResp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [
         ]);
         $movePageResp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [

-            'name' => 'My copied test page',
+            'name'       => 'My copied test page',

             'created_by' => $viewer->id,
             'created_by' => $viewer->id,

-            'book_id' => $newBook->id,
+            'book_id'    => $newBook->id,

         ]);
     }
 
         ]);
     }
 

-    public function test_empty_markdown_still_saves_without_error()
+    public function test_old_page_slugs_redirect_to_new_pages()

     {
     {

-        $this->setSettings(['app-editor' => 'markdown']);
-        $book = Book::query()->first();
+        $page = $this->entities->page();

 
 

-        $this->asEditor()->get($book->getUrl('/create-page'));
-        $draft = Page::query()->where('book_id', '=', $book->id)
-            ->where('draft', '=', true)->first();
+        // Need to save twice since revisions are not generated in seeder.
+        $this->asAdmin()->put($page->getUrl(), [
+            'name' => 'super test',
+            'html' => '<p></p>',
+        ]);

 
 

-        $details = [
-            'name' => 'my page',
-            'markdown' => '',
-        ];
-        $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
-        $resp->assertRedirect();
+        $page->refresh();
+        $pageUrl = $page->getUrl();

 
 

-        $this->assertDatabaseHas('pages', [
-            'markdown' => $details['markdown'],
-            'id' => $draft->id,
-            'draft' => false
+        $this->put($pageUrl, [
+            'name' => 'super test page',
+            'html' => '<p></p>',
+        ]);
+
+        $this->get($pageUrl)
+            ->assertRedirect("/books/{$page->book->slug}/page/super-test-page");
+    }
+
+    public function test_page_within_chapter_deletion_returns_to_chapter()
+    {
+        $chapter = $this->entities->chapter();
+        $page = $chapter->pages()->first();
+
+        $this->asEditor()->delete($page->getUrl())
+            ->assertRedirect($chapter->getUrl());
+    }
+
+    public function test_recently_updated_pages_view()
+    {
+        $user = $this->users->editor();
+        $content = $this->entities->createChainBelongingToUser($user);
+
+        $resp = $this->asAdmin()->get('/pages/recently-updated');
+        $this->withHtml($resp)->assertElementContains('.entity-list .page:nth-child(1)', $content['page']->name);
+    }
+
+    public function test_recently_updated_pages_view_shows_updated_by_details()
+    {
+        $user = $this->users->editor();
+        $page = $this->entities->page();
+
+        $this->actingAs($user)->put($page->getUrl(), [
+            'name' => 'Updated title',
+            'html' => '<p>Updated content</p>',

         ]);
         ]);

+
+        $resp = $this->asAdmin()->get('/pages/recently-updated');
+        $this->withHtml($resp)->assertElementContains('.entity-list .page:nth-child(1)', 'Updated 0 seconds ago by ' . $user->name);
+    }
+
+    public function test_recently_updated_pages_view_shows_parent_chain()
+    {
+        $user = $this->users->editor();
+        $page = $this->entities->pageWithinChapter();
+
+        $this->actingAs($user)->put($page->getUrl(), [
+            'name' => 'Updated title',
+            'html' => '<p>Updated content</p>',
+        ]);
+
+        $resp = $this->asAdmin()->get('/pages/recently-updated');
+        $this->withHtml($resp)->assertElementContains('.entity-list .page:nth-child(1)', $page->chapter->getShortName(42));
+        $this->withHtml($resp)->assertElementContains('.entity-list .page:nth-child(1)', $page->book->getShortName(42));
+    }
+
+    public function test_recently_updated_pages_view_does_not_show_parent_if_not_visible()
+    {
+        $user = $this->users->editor();
+        $page = $this->entities->pageWithinChapter();
+
+        $this->actingAs($user)->put($page->getUrl(), [
+            'name' => 'Updated title',
+            'html' => '<p>Updated content</p>',
+        ]);
+
+        $this->permissions->setEntityPermissions($page->book);
+        $this->permissions->setEntityPermissions($page, ['view'], [$user->roles->first()]);
+
+        $resp = $this->get('/pages/recently-updated');
+        $resp->assertDontSee($page->book->getShortName(42));
+        $resp->assertDontSee($page->chapter->getShortName(42));
+        $this->withHtml($resp)->assertElementContains('.entity-list .page:nth-child(1)', 'Updated title');
+    }
+
+    public function test_recently_updated_pages_on_home()
+    {
+        /** @var Page $page */
+        $page = Page::query()->orderBy('updated_at', 'asc')->first();
+        Page::query()->where('id', '!=', $page->id)->update([
+            'updated_at' => Carbon::now()->subSecond(1),
+        ]);
+
+        $resp = $this->asAdmin()->get('/');
+        $this->withHtml($resp)->assertElementNotContains('#recently-updated-pages', $page->name);
+
+        $this->put($page->getUrl(), [
+            'name' => $page->name,
+            'html' => $page->html,
+        ]);
+
+        $resp = $this->get('/');
+        $this->withHtml($resp)->assertElementContains('#recently-updated-pages', $page->name);

     }
     }

-}
\ No newline at end of file
+}