- $sortMap = json_decode($request->get('sort-tree'));
- $defaultBookId = $book->id;
- foreach ($sortMap as $index => $bookChild) {
- $id = $bookChild->id;
- $isPage = $bookChild->type == 'page';
- $bookId = $this->bookRepo->exists($bookChild->book) ? $bookChild->book : $defaultBookId;
- $model = $isPage ? $this->pageRepo->getById($id) : $this->chapterRepo->getById($id);
- $isPage ? $this->pageRepo->changeBook($bookId, $model) : $this->chapterRepo->changeBook($bookId, $model);
- $model->priority = $index;
- if ($isPage) {
- $model->chapter_id = ($bookChild->parentChapter === false) ? 0 : $bookChild->parentChapter;
+ $sortMap = collect(json_decode($request->get('sort-tree')));
+ $bookIdsInvolved = collect([$book->id]);
+
+ // Load models into map
+ $sortMap->each(function ($mapItem) use ($bookIdsInvolved) {
+ $mapItem->type = ($mapItem->type === 'page' ? 'page' : 'chapter');
+ $mapItem->model = $this->entityRepo->getById($mapItem->type, $mapItem->id);
+ // Store source and target books
+ $bookIdsInvolved->push(intval($mapItem->model->book_id));
+ $bookIdsInvolved->push(intval($mapItem->book));
+ });
+
+ // Get the books involved in the sort
+ $bookIdsInvolved = $bookIdsInvolved->unique()->toArray();
+ $booksInvolved = $this->entityRepo->book->newQuery()->whereIn('id', $bookIdsInvolved)->get();
+ // Throw permission error if invalid ids or inaccessible books given.
+ if (count($bookIdsInvolved) !== count($booksInvolved)) {
+ $this->showPermissionError();
+ }
+ // Check permissions of involved books
+ $booksInvolved->each(function (Book $book) {
+ $this->checkOwnablePermission('book-update', $book);
+ });
+
+ // Perform the sort
+ $sortMap->each(function ($mapItem) {
+ $model = $mapItem->model;
+
+ $priorityChanged = intval($model->priority) !== intval($mapItem->sort);
+ $bookChanged = intval($model->book_id) !== intval($mapItem->book);
+ $chapterChanged = ($mapItem->type === 'page') && intval($model->chapter_id) !== $mapItem->parentChapter;
+
+ if ($bookChanged) {
+ $this->entityRepo->changeBook($mapItem->type, $mapItem->book, $model);