fix deprecated syntax

[bookstack] / app / Search / SearchController.php

diff --git a/app/Search/SearchController.php b/app/Search/SearchController.php
index 6cf12a57920631ecebdff6fdddf01938d80f1ac6..2fce6a3d53fb86e14e1b773f4126f0b1ba456fb2 100644 (file)
--- a/app/Search/SearchController.php
+++ b/app/Search/SearchController.php
@@ -2,8 +2,8 @@
 
 namespace BookStack\Search;
 
 
 namespace BookStack\Search;
 

-use BookStack\Entities\Models\Page;
-use BookStack\Entities\Queries\Popular;
+use BookStack\Entities\Queries\PageQueries;
+use BookStack\Entities\Queries\QueryPopular;

 use BookStack\Entities\Tools\SiblingFetcher;
 use BookStack\Http\Controller;
 use Illuminate\Http\Request;
 use BookStack\Entities\Tools\SiblingFetcher;
 use BookStack\Http\Controller;
 use Illuminate\Http\Request;


@@ -11,7 +11,8 @@ use Illuminate\Http\Request;
 class SearchController extends Controller
 {
     public function __construct(
 class SearchController extends Controller
 {
     public function __construct(

-        protected SearchRunner $searchRunner
+        protected SearchRunner $searchRunner,
+        protected PageQueries $pageQueries,

     ) {
     }
 
     ) {
     }
 


@@ -66,7 +67,7 @@ class SearchController extends Controller
      * Search for a list of entities and return a partial HTML response of matching entities.
      * Returns the most popular entities if no search is provided.
      */
      * Search for a list of entities and return a partial HTML response of matching entities.
      * Returns the most popular entities if no search is provided.
      */

-    public function searchForSelector(Request $request)
+    public function searchForSelector(Request $request, QueryPopular $queryPopular)

     {
         $entityTypes = $request->filled('types') ? explode(',', $request->get('types')) : ['page', 'chapter', 'book'];
         $searchTerm = $request->get('term', false);
     {
         $entityTypes = $request->filled('types') ? explode(',', $request->get('types')) : ['page', 'chapter', 'book'];
         $searchTerm = $request->get('term', false);


@@ -77,7 +78,7 @@ class SearchController extends Controller
             $searchTerm .= ' {type:' . implode('|', $entityTypes) . '}';
             $entities = $this->searchRunner->searchEntities(SearchOptions::fromString($searchTerm), 'all', 1, 20)['results'];
         } else {
             $searchTerm .= ' {type:' . implode('|', $entityTypes) . '}';
             $entities = $this->searchRunner->searchEntities(SearchOptions::fromString($searchTerm), 'all', 1, 20)['results'];
         } else {

-            $entities = (new Popular())->run(20, 0, $entityTypes);
+            $entities = $queryPopular->run(20, 0, $entityTypes);

         }
 
         return view('search.parts.entity-selector-list', ['entities' => $entities, 'permission' => $permission]);
         }
 
         return view('search.parts.entity-selector-list', ['entities' => $entities, 'permission' => $permission]);


@@ -95,12 +96,11 @@ class SearchController extends Controller
             $searchOptions->setFilter('is_template');
             $entities = $this->searchRunner->searchEntities($searchOptions, 'page', 1, 20)['results'];
         } else {
             $searchOptions->setFilter('is_template');
             $entities = $this->searchRunner->searchEntities($searchOptions, 'page', 1, 20)['results'];
         } else {

-            $entities = Page::visible()
-                ->where('template', '=', true)
+            $entities = $this->pageQueries->visibleTemplates()

                 ->where('draft', '=', false)
                 ->orderBy('updated_at', 'desc')
                 ->take(20)
                 ->where('draft', '=', false)
                 ->orderBy('updated_at', 'desc')
                 ->take(20)

-                ->get(Page::$listAttributes);
+                ->get();

         }
 
         return view('search.parts.entity-selector-list', [
         }
 
         return view('search.parts.entity-selector-list', [


@@ -130,12 +130,12 @@ class SearchController extends Controller
     /**
      * Search siblings items in the system.
      */
     /**
      * Search siblings items in the system.
      */

-    public function searchSiblings(Request $request)
+    public function searchSiblings(Request $request, SiblingFetcher $siblingFetcher)

     {
         $type = $request->get('entity_type', null);
         $id = $request->get('entity_id', null);
 
     {
         $type = $request->get('entity_type', null);
         $id = $request->get('entity_id', null);
 

-        $entities = (new SiblingFetcher())->fetch($type, $id);
+        $entities = $siblingFetcher->fetch($type, $id);

 
         return view('entities.list-basic', ['entities' => $entities, 'style' => 'compact']);
     }
 
         return view('entities.list-basic', ['entities' => $entities, 'style' => 'compact']);
     }